[keyserver] Bump `notification.mutableContent` version gate to 1000
ClosedPublic
Actions

Authored by atul on Jul 28 2022, 9:46 AM.

Details

Reviewers

ashoat
marcin
tomek

Commits

rCOMM8a1bb457ce1f: [keyserver] Bump `notification.mutableContent` version gate to 1000

Summary

Want to defer this for now to isolate changes while troubleshooting iOS crashes.

Test Plan

Diff Detail

Repository

rCOMM Comm

Branch

july28 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jul 28 2022, 9:46 AM

Herald added subscribers: • abosh, • adrian. · View Herald TranscriptJul 28 2022, 9:46 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 28 2022, 9:52 AM

Harbormaster failed remote builds in B10951: Diff 15063!

Harbormaster completed remote builds in B10951: Diff 15063.Jul 28 2022, 10:01 AM

atul requested review of this revision.Jul 28 2022, 10:01 AM

ashoat accepted this revision.Jul 28 2022, 10:01 AM

This revision is now accepted and ready to land.Jul 28 2022, 10:01 AM

Closed by commit rCOMM8a1bb457ce1f: [keyserver] Bump `notification.mutableContent` version gate to 1000 (authored by atul). · Explain WhyJul 28 2022, 10:12 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM8a1bb457ce1f: [keyserver] Bump `notification.mutableContent` version gate to 1000.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

push/

send.js

2 lines

Diff 15063

View Options

keyserver/src/push/send.js

use actix_web::{		use actix_web::{
error::{		error::{
ErrorBadRequest, ErrorConflict, ErrorInternalServerError,		ErrorBadRequest, ErrorConflict, ErrorInternalServerError,
ErrorServiceUnavailable, HttpError,		ErrorServiceUnavailable, HttpError,
},		},
HttpResponse, ResponseError,		HttpResponse, ResponseError,
};		};
		pub use aws_sdk_dynamodb::Error as DynamoDBError;
use comm_services_lib::blob::client::BlobServiceError;		use comm_services_lib::blob::client::BlobServiceError;
		use comm_services_lib::database::Error as DBError;
use reqwest::StatusCode;		use reqwest::StatusCode;
use tracing::{error, trace, warn};		use tracing::{error, trace, warn};

#[derive(		#[derive(
Debug, derive_more::Display, derive_more::From, derive_more::Error,		Debug, derive_more::Display, derive_more::From, derive_more::Error,
)]		)]
pub enum BackupError {		pub enum BackupError {
BlobError(BlobServiceError),		BlobError(BlobServiceError),
		DB(comm_services_lib::database::Error),
}		}

impl From<&BackupError> for actix_web::Error {		impl From<&BackupError> for actix_web::Error {
fn from(value: &BackupError) -> Self {		fn from(value: &BackupError) -> Self {
trace!("Handling backup service error: {value}");		trace!("Handling backup service error: {value}");
match value {		match value {
BackupError::BlobError(		BackupError::BlobError(
err @ (BlobServiceError::ClientError(_)		err @ (BlobServiceError::ClientError(_)
Show All 10 Lines	match value {
ErrorBadRequest("bad request")		ErrorBadRequest("bad request")
}		}
BackupError::BlobError(		BackupError::BlobError(
err @ (BlobServiceError::URLError(_) \| BlobServiceError::NotFound),		err @ (BlobServiceError::URLError(_) \| BlobServiceError::NotFound),
) => {		) => {
error!("Unexpected blob error: {err}");		error!("Unexpected blob error: {err}");
ErrorInternalServerError("server error")		ErrorInternalServerError("server error")
}		}
		BackupError::DB(err) => match err {
		DBError::AwsSdk(
		err @ (DynamoDBError::InternalServerError(_)
		\| DynamoDBError::ProvisionedThroughputExceededException(_)
		\| DynamoDBError::RequestLimitExceeded(_)),
		) => {
		warn!("AWS transient error occurred: {err}");
		ErrorServiceUnavailable("please retry")
		}
		unexpected => {
		error!("Received an unexpected DB error: {0:?} - {0}", unexpected);
		ErrorInternalServerError("server error")
		}
		},
}		}
}		}
}		}

impl From<BackupError> for HttpError {		impl From<BackupError> for HttpError {
fn from(value: BackupError) -> Self {		fn from(value: BackupError) -> Self {
value.into()		value.into()
}		}
Show All 13 Lines

[keyserver] Bump `notification.mutableContent` version gate to 1000ClosedPublicActions