Page MenuHomePhabricator
Differential D4669

[web] Make "Mark as unread" button easier to click reliably
ClosedPublic
Actions

Authored by atul on Jul 28 2022, 11:32 AM.
Tags
None
Referenced Files
F3370666: D4669.id15065.diff
Tue, Nov 26, 3:37 AM
F3370229: D4669.diff
Tue, Nov 26, 1:32 AM
Unknown Object (File)
Sat, Nov 9, 11:35 AM
Unknown Object (File)
Fri, Nov 8, 8:29 PM
Unknown Object (File)
Fri, Nov 8, 8:29 PM
Unknown Object (File)
Fri, Nov 8, 8:29 PM
Unknown Object (File)
Tue, Nov 5, 2:05 AM
Unknown Object (File)
Oct 19 2024, 7:21 PM
View All Files
Subscribers
• adrian
ashoat

Details

Reviewers
tomek
• abosh
varun
• jacek
ashoat
Commits
rCOMM67f60aecbf52: [web] Make "Mark as unread" button easier to click reliably
Summary

Context: https://linear.app/comm/issue/ENG-992/mark-as-unread-button-can-be-hard-to-press-on-web

Users reported that sometimes the "Mark as unread" button would disappear before they were able to click it. It looks like this was because there was a 1px gap (see image below) between the menu button (vertical ellipsis) and the toggle unread status button ("Mark as unread") where onMouseLeave would trigger and hide the toggle unread status button.

Screen Shot 2022-07-28 at 2.20.46 PM.png (1×1 px, 59 KB)

I was able to reproduce this issue consistently when moving the cursor slowly from the vertical ellipsis to "Mark as unread" button, but was able to avoid the issue by moving my cursor "fast." Not sure why onMouseLeave doesn't trigger if you move the cursor back within the div fast enough, but that's the behavior I observed.

This diff basically closes that 1px gap and gets things working reliably.

Test Plan

Was able to consistently mark a thread as read/unread without the "Mark as unread" button disappearing.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Jul 28 2022, 11:32 AM
Herald added subscribers: • adrian, ashoat. · View Herald TranscriptJul 28 2022, 11:32 AM
atul edited the summary of this revision. (Show Details)Jul 28 2022, 11:33 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 28 2022, 11:38 AM
Harbormaster failed remote builds in B10952: Diff 15065!
Harbormaster completed remote builds in B10952: Diff 15065.Jul 28 2022, 11:57 AM
atul requested review of this revision.Jul 28 2022, 11:57 AM
• abosh accepted this revision.Jul 28 2022, 12:08 PM
This revision is now accepted and ready to land.Jul 28 2022, 12:08 PM
atul added 1 blocking reviewer(s): varun.Jul 28 2022, 12:24 PM
This revision now requires review to proceed.Jul 28 2022, 12:24 PM
atul added 1 blocking reviewer(s): tomek.Jul 28 2022, 12:24 PM
atul added a comment.Jul 28 2022, 12:57 PM

Here's where the + 1px was introduced: https://phab.comm.dev/D462

Based on the diff description I think this was a visual/style change and wasn't to fix some other bug/issue

(cc @ashoat)

varun accepted this revision.Jul 28 2022, 12:58 PM
atul added a reviewer: ashoat. atul removed 1 blocking reviewer(s): tomek.Jul 28 2022, 12:59 PM
ashoat added a comment.Jul 28 2022, 1:59 PM

No context, seems good

web/chat/chat-thread-list-item-menu.css
44 ↗(On Diff #15065)

Pretty sure we don't need calc if it's just 100%, can't we just use 100%?

ashoat accepted this revision.Jul 28 2022, 11:25 PM

Please look into just using 100% before landing, I think it's the same

This revision is now accepted and ready to land.Jul 28 2022, 11:25 PM
atul updated this revision to Diff 15094.Jul 29 2022, 8:30 AM

remove unnecessary calc(...)

atul added a comment.Jul 29 2022, 8:32 AM
In D4669#134345, @ashoat wrote:

Please look into just using 100% before landing, I think it's the same

Yeah they're the same, updated this diff.

Harbormaster completed remote builds in B10972: Diff 15094.Jul 29 2022, 8:43 AM
Closed by commit rCOMM67f60aecbf52: [web] Make "Mark as unread" button easier to click reliably (authored by atul). · Explain WhyJul 29 2022, 8:45 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM67f60aecbf52: [web] Make "Mark as unread" button easier to click reliably.

Revision Contents
Changeset List

PathSize
web/
chat/
2 lines

Diff 15099

View Options

web/chat/chat-thread-list-item-menu.css

Loading...