Page MenuHomePhabricator

[Nix] Fix arc diff
ClosedPublic

Authored by jon on Jul 29 2022, 4:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 10:11 AM
Unknown Object (File)
Mon, Dec 16, 10:11 AM
Unknown Object (File)
Mon, Dec 16, 12:50 AM
Unknown Object (File)
Nov 18 2024, 10:28 AM
Unknown Object (File)
Nov 18 2024, 10:18 AM
Unknown Object (File)
Nov 18 2024, 8:51 AM
Unknown Object (File)
Nov 2 2024, 4:22 AM
Unknown Object (File)
Nov 2 2024, 4:22 AM

Details

Summary

Noticed that arc diff was failing in new terminal sessions
due to sh: line 1: php: command not found. Looks like some arcanist commands
forks the process and some logic still calls php. This just adds php
to PATH.

Test Plan
# somehow remove PHP from path? or just trust me :)
# This can be used from any branch
nix develop github:commE2E/comm?ref=jonringer/fix-arcanist

# use `arc diff` or another command which forks the process

Diff Detail

Repository
rCOMM Comm
Branch
jonringer/fix-arcanist
Lint
No Lint Coverage
Unit
No Test Coverage