[Nix] Fix arc diff
ClosedPublic
Actions

Authored by • jon on Jul 29 2022, 4:32 PM.

Tags

None

Referenced Files

	F3303121: D4688.id15139.diff
	Mon, Nov 18, 10:28 AM

	F3303097: D4688.id15126.diff
	Mon, Nov 18, 10:18 AM

	F3302885: D4688.diff
	Mon, Nov 18, 8:51 AM

	Unknown Object (File)
	Sat, Nov 2, 4:22 AM

	Unknown Object (File)
	Sat, Nov 2, 4:22 AM

	Unknown Object (File)
	Sat, Nov 2, 4:22 AM

	Unknown Object (File)
	Sat, Nov 2, 4:20 AM

	Unknown Object (File)
	Oct 8 2024, 7:58 AM

Subscribers

Details

Reviewers

varun
ashoat

Commits

rCOMMdd0fa633504e: [Nix] Fix arc diff

Summary

Noticed that arc diff was failing in new terminal sessions
due to sh: line 1: php: command not found. Looks like some arcanist commands
forks the process and some logic still calls php. This just adds php
to PATH.

Test Plan

# somehow remove PHP from path? or just trust me :)
# This can be used from any branch
nix develop github:commE2E/comm?ref=jonringer/fix-arcanist

# use `arc diff` or another command which forks the process