Paths

Table of Contentst

[web] Finish styling `MessageTimestampTooltip`
ClosedPublic
Actions

Authored by • abosh on Aug 1 2022, 1:48 PM.

Details

Reviewers

atul
• jacek
tomek

Commits

rCOMM33347778d029: [web] Finish styling `MessageTimestampTooltip`

Summary

Relevant Linear issue here.

This diff adds styling changes to MessageTimestampTooltip, specifically changing the color of the tooltip, increasing the width of the tooltip (so it is at minimum the width of the MessageTooltip with the reply/create thread buttons), some padding, and makes the border radius match the MessageTooltip.

Depends on D4704.

Test Plan

Tested on Chrome/Safari and looks as expected:
Chrome:

Safari:

Additional stills:

Finally, the timestamp does not appear behind photos, as @ashoat noted on Linear:

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• abosh created this revision.Aug 1 2022, 1:48 PM

Herald added subscribers: • adrian, ashoat. · View Herald TranscriptAug 1 2022, 1:48 PM

• abosh edited the test plan for this revision. (Show Details)Aug 1 2022, 1:51 PM

Harbormaster completed remote builds in B11036: Diff 15178.Aug 1 2022, 1:58 PM

• abosh requested review of this revision.Aug 1 2022, 1:58 PM

Un-modify --tool-tip-bg in theme.css. Since we want the MessageTimestampTooltip color to match MessageTooltip, we can just set background-color to --message-action-tooltip-bg, as done in line 44 of tooltip.css of this diff, since --message-action-tooltip-bg sets the color of MessageTooltip.

Harbormaster completed remote builds in B11040: Diff 15182.Aug 1 2022, 7:15 PM

• jacek accepted this revision.Aug 2 2022, 1:06 AM

• jacek added inline comments.

web/chat/tooltip.react.js
71 ↗	(On Diff #15182)	I think it would be better to put the new class into existing `classNames` in `useMemo` in line 63. Now, `className` here is calculated every render.

This revision is now accepted and ready to land.Aug 2 2022, 1:06 AM

• abosh marked an inline comment as done.Aug 2 2022, 8:44 AM

• abosh added inline comments.

web/chat/tooltip.react.js
71 ↗	(On Diff #15182)	Great catch!

Put .messageTimestampTooltip CSS class in the useMemo on line 62 so it is memoized, per @jacek's feedback.

• abosh edited the test plan for this revision. (Show Details)Aug 2 2022, 8:50 AM

• abosh edited the test plan for this revision. (Show Details)

Adding @tomek and @atul as blocking to get at least one more set of eyes on this, although the rest of the stack prior to this diff still needs to be reviewed.

This revision now requires review to proceed.Aug 2 2022, 8:55 AM

Harbormaster completed remote builds in B11053: Diff 15215.Aug 2 2022, 8:55 AM

atul accepted this revision.Aug 4 2022, 10:22 AM

• abosh removed 1 blocking reviewer(s): tomek.Aug 4 2022, 10:29 AM

This revision is now accepted and ready to land.Aug 4 2022, 10:29 AM

Closed by commit rCOMM33347778d029: [web] Finish styling `MessageTimestampTooltip` (authored by • abosh). · Explain WhyAug 4 2022, 10:45 AM

This revision was automatically updated to reflect the committed changes.

• abosh added a commit: rCOMM33347778d029: [web] Finish styling `MessageTimestampTooltip`.