[native] expose module with generated tonic client code
ClosedPublic
Actions

Authored by varun on Aug 1 2022, 2:18 PM.

Details

Reviewers

tomek
• karol
• jon

Commits

rCOMMb9c034b64a9c: [native] expose module with generated tonic client code

Summary

the build.rs script generates rust code from the identity.proto file. we then use the include_proto macro to expose the generated code as a module in our library

Test Plan

cargo build

Diff Detail

Repository

rCOMM Comm

Branch

identity-client (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Aug 1 2022, 2:18 PM

Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptAug 1 2022, 2:18 PM

Harbormaster completed remote builds in B11038: Diff 15180.Aug 1 2022, 2:31 PM

varun requested review of this revision.Aug 1 2022, 2:31 PM

I'm not exactly sure how we handle .proto files in other services, but we should be consistent. Could you check what is the approach to generating source code from proto files? (if we do that during build time, or generate them by hand, before the build process) Also, if the good practices suggest that we should do that during build process, we might want to take this approach in all the places.

This revision now requires changes to proceed.Aug 2 2022, 2:32 AM

@jon is the expert on proto generation in native. More context in ENG-777... basically we don't have a way to generate these during build time on iOS yet (tracked in ENG-1529), so for now we check in the .proto files to the repo.