Paths

Table of Contentst

Differential D4683

[native] rust project for native gRPC client
ClosedPublic
Actions

Authored by varun on Jul 29 2022, 11:25 AM.

Tags

None

Referenced Files

	F3509216: D4683.id15114.diff
	Sat, Dec 21, 2:34 AM

	F3508842: D4683.diff
	Fri, Dec 20, 11:59 PM

	Unknown Object (File)
	Mon, Dec 16, 10:11 AM

	Unknown Object (File)
	Mon, Dec 16, 12:50 AM

	Unknown Object (File)
	Mon, Dec 16, 12:50 AM

	Unknown Object (File)
	Mon, Dec 16, 12:50 AM

	Unknown Object (File)
	Mon, Dec 16, 12:49 AM

	Unknown Object (File)
	Mon, Dec 16, 12:49 AM

Subscribers

Details

Reviewers

tomek
• karol
ashoat

Commits

rCOMM5d4131ef61ab: [native] rust project for native gRPC client

Summary

set up the Cargo project with some obvious dependencies

Test Plan

cargo build

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Jul 29 2022, 11:25 AM

Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptJul 29 2022, 11:25 AM

Harbormaster completed remote builds in B10980: Diff 15114.Jul 29 2022, 11:38 AM

varun requested review of this revision.Jul 29 2022, 11:38 AM

tomek requested changes to this revision.Aug 1 2022, 1:57 AM

tomek added inline comments.

native/cpp/CommonCpp/grpc/grpc_client/Cargo.toml
13 ↗	(On Diff #15114)	The most recent version is `0.8.0` - why do we use an older one?
14 ↗	(On Diff #15114)	Is there a reason to not use `0.11`?

This revision now requires changes to proceed.Aug 1 2022, 1:57 AM

• karol added inline comments.Aug 1 2022, 2:30 AM

native/cpp/CommonCpp/grpc/grpc_client/src/lib.rs
1 ↗	(On Diff #15114)	What is this?

update dependencies

native/cpp/CommonCpp/grpc/grpc_client/Cargo.toml
13 ↗	(On Diff #15114)	I copied the versions from the Identity service, but there's no reason not to use the latest versions I suppose
native/cpp/CommonCpp/grpc/grpc_client/src/lib.rs
1 ↗	(On Diff #15114)	since this is a library crate, we need a `lib.rs` file or else `cargo` will complain

Harbormaster completed remote builds in B11018: Diff 15154.Aug 1 2022, 11:57 AM

add one more dep

varun added a reviewer: ashoat.Aug 1 2022, 1:08 PM

Harbormaster completed remote builds in B11029: Diff 15170.Aug 1 2022, 1:21 PM

These all look legit

forgot to bump the tonic-build version to match tonic

Harbormaster completed remote builds in B11037: Diff 15179.Aug 1 2022, 2:29 PM

tomek accepted this revision.Aug 2 2022, 2:42 AM

This revision is now accepted and ready to land.Aug 2 2022, 2:42 AM

Closed by commit rCOMM5d4131ef61ab: [native] rust project for native gRPC client (authored by varun). · Explain WhyAug 2 2022, 7:51 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM5d4131ef61ab: [native] rust project for native gRPC client.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

grpc/

grpc_client/

19 lines

src/

1 line

Diff 15210

native/cpp/CommonCpp/grpc/grpc_client/Cargo.lock

Loading...

native/cpp/CommonCpp/grpc/grpc_client/Cargo.toml

Loading...

native/cpp/CommonCpp/grpc/grpc_client/src/lib.rs

Loading...