Page MenuHomePhabricator

[native] Clean up `build_openssl.sh` using ShellCheck
ClosedPublic

Authored by abosh on Aug 2 2022, 9:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 2, 5:29 PM
Unknown Object (File)
Sun, Oct 27, 4:43 PM
Unknown Object (File)
Oct 8 2024, 9:26 AM
Unknown Object (File)
Oct 8 2024, 8:02 AM
Unknown Object (File)
Oct 8 2024, 6:31 AM
Unknown Object (File)
Oct 8 2024, 5:12 AM
Unknown Object (File)
Oct 7 2024, 10:34 AM
Unknown Object (File)
Oct 7 2024, 10:34 AM
Subscribers

Details

Summary

Related Linear issue here. This is part of a set of diffs that will allow ShellCheck to be added to the CI. See inline comments for specific details of the ShellCheck error/warning output.

Test Plan

ShellCheck.

Additionally, build_openssl.sh is run during the Android build so if that workflow continues to pass CI we can reasonably assume that the script continues to work as expected.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Outside of running shellcheck, we should ensure that the script continues to work as expected and specify how we can check that in the Test Plan.

eg something like:

build_openssl.sh is run during the Android build so if that workflow continues to pass CI we can reasonably assume that the script continues to work as expected

This revision is now accepted and ready to land.Aug 2 2022, 10:35 AM
In D4716#135609, @atul wrote:

Outside of running shellcheck, we should ensure that the script continues to work as expected and specify how we can check that in the Test Plan.

eg something like:

build_openssl.sh is run during the Android build so if that workflow continues to pass CI we can reasonably assume that the script continues to work as expected

Great point. I'll start doing that from now on/will modify prior diffs. I think because this diff only added double quotes I got lazy and wasn't thorough in the Test Plan.