Related Linear issue here. This is part of a set of diffs that will allow ShellCheck to be added to the CI. See inline comments for specific details of the ShellCheck error/warning output.
Details
Additionally, build_openssl.sh is run during the Android build so if that workflow continues to pass CI we can reasonably assume that the script continues to work as expected.
Diff Detail
- Repository
- rCOMM Comm
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Every change made in this file was double quote to prevent globbing and word splitting.
Outside of running shellcheck, we should ensure that the script continues to work as expected and specify how we can check that in the Test Plan.
eg something like:
build_openssl.sh is run during the Android build so if that workflow continues to pass CI we can reasonably assume that the script continues to work as expected
Great point. I'll start doing that from now on/will modify prior diffs. I think because this diff only added double quotes I got lazy and wasn't thorough in the Test Plan.