Page MenuHomePhabricator
Differential D4746

[services] Tunnelbroker - Changes in Amqp messages testing to send and listen in different threads
ClosedPublic
Actions

Authored by • max on Aug 4 2022, 12:36 PM.
Tags
None
Referenced Files
F3349986: D4746.diff
Fri, Nov 22, 8:06 PM
Unknown Object (File)
Mon, Oct 28, 2:58 AM
Unknown Object (File)
Sun, Oct 27, 6:17 AM
Unknown Object (File)
Sun, Oct 27, 6:17 AM
Unknown Object (File)
Sun, Oct 27, 6:17 AM
Unknown Object (File)
Sun, Oct 27, 6:17 AM
Unknown Object (File)
Sun, Oct 27, 6:17 AM
Unknown Object (File)
Sun, Oct 27, 6:16 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• karol
tomek

Details

Reviewers
• karol
tomek
Commits
rCOMM6b7ed9068114: [services] Tunnelbroker - Changes in Amqp messages testing to send and listen…
Summary

In real-world usage sending and receiving messages in the AMQP client (AMQP Manager) would be in different threads.
This diff changes sending messages from another than the main thread. Listening (message pop) is in blocking mode in the main thread without changes.

Related Linear task: ENG-1491

Test Plan

Successfully built using yarn run-tunnelbroker-service-in-sandbox command.
Passing all AMQP unit tests in the last diff D4749 in a stack.

Diff Detail

Repository
rCOMM Comm
Branch
fix-amqp-tests-to-use-thread
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• max created this revision.Aug 4 2022, 12:36 PM
• max held this revision as a draft.
Herald added subscribers: • abosh, • karol, atul and 3 others. · View Herald TranscriptAug 4 2022, 12:36 PM
Harbormaster completed remote builds in B11135: Diff 15333.Aug 4 2022, 12:49 PM
• max edited the summary of this revision. (Show Details)Aug 4 2022, 4:28 PM
• max edited the test plan for this revision. (Show Details)
• max added reviewers: • karol, tomek.
• max added parent revisions: D4744: [services] Tunnelbroker - Fix AMQP client reconnection algorithm, D4745: [services] Tunnelbroker - Fix message `from` and `to` swap in AMQP tests.
• max added a child revision: D4749: [services] Tunnelbroker - Add timeout for a pop message waiting in AmqpManager tests.Aug 4 2022, 4:45 PM
• max published this revision for review.Aug 4 2022, 4:55 PM
• max edited the test plan for this revision. (Show Details)
• max updated this revision to Diff 15404.Aug 6 2022, 11:58 AM

Rebase on parent changes.

• max added a parent revision: D4767: [services] Tunnelbroker - Add AMQP shared channel locking.Aug 6 2022, 11:59 AM
Harbormaster completed remote builds in B11195: Diff 15404.Aug 6 2022, 12:10 PM
• max updated this revision to Diff 15409.Aug 6 2022, 12:46 PM

Rebase on master changes.

Harbormaster completed remote builds in B11200: Diff 15409.Aug 6 2022, 12:58 PM
• max added a child revision: D4768: [services] Tunnelbroker - Amqp Manager in parallel threads messages throughput test.Aug 6 2022, 1:06 PM
• karol accepted this revision.Aug 8 2022, 5:14 AM
tomek accepted this revision.Aug 9 2022, 9:35 AM
tomek added inline comments.
services/tunnelbroker/test/AmqpManagerTest.cpp
41

Is there a reason to not capture by reference?

This revision is now accepted and ready to land.Aug 9 2022, 9:35 AM
• max updated this revision to Diff 15914.Aug 24 2022, 4:30 AM

Rebase and merge on a master changes.

• max updated this revision to Diff 15915.Aug 24 2022, 4:32 AM

Minor fix with removing the ini file from the commit.

Harbormaster completed remote builds in B11574: Diff 15914.Aug 24 2022, 4:41 AM
Harbormaster completed remote builds in B11575: Diff 15915.
• max marked an inline comment as done.Aug 24 2022, 4:54 AM
• max added inline comments.
services/tunnelbroker/test/AmqpManagerTest.cpp
41

Is there a reason to not capture by reference?

Yes, we can! I've made these changes. Thanks!

Closed by commit rCOMM6b7ed9068114: [services] Tunnelbroker - Changes in Amqp messages testing to send and listen… (authored by • max). · Explain WhyAug 24 2022, 4:55 AM
This revision was automatically updated to reflect the committed changes.
• max marked an inline comment as done.
• max added a commit: rCOMM6b7ed9068114: [services] Tunnelbroker - Changes in Amqp messages testing to send and listen….
• max removed a child revision: D4768: [services] Tunnelbroker - Amqp Manager in parallel threads messages throughput test.Aug 24 2022, 5:35 AM

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
test/
12 lines

Diff 15409

View Options

services/tunnelbroker/test/AmqpManagerTest.cpp

Loading...