Paths

Table of Contentst

Differential D4806

[native] Fix message tooltip positioning for robotext with sidebar
ClosedPublic
Actions

Authored by • jacek on Aug 11 2022, 3:58 AM.

Tags

None

Referenced Files

	F3396948: D4806.id15546.diff
	Sun, Dec 1, 3:38 PM

	Unknown Object (File)
	Tue, Nov 26, 1:31 AM

	Unknown Object (File)
	Mon, Nov 25, 11:36 PM

	Unknown Object (File)
	Fri, Nov 22, 11:56 PM

	Unknown Object (File)
	Mon, Nov 18, 3:15 PM

	Unknown Object (File)
	Mon, Nov 11, 4:19 AM

	Unknown Object (File)
	Sat, Nov 9, 11:44 PM

	Unknown Object (File)
	Sat, Nov 9, 9:15 PM

View All 75 Files

Subscribers

Details

Reviewers

tomek
atul
• abosh

Commits

rCOMM0971b214372a: [native] Fix message tooltip positioning for robotext with sidebar

Summary

The diff fixes: https://linear.app/comm/issue/ENG-1591/messagetooltip-renders-in-wrong-place-if-robotext-message-contains
It moves inlineSidebar for robotext messages one level higher in component tree, so it won't be included when measuring message position and size - like it is with composedMessage.

Test Plan

Test if toolptip displays correctly on android and iOS, confirm that animations for opening or creating sidebar modal still works as before.

Diff Detail

Repository

Branch

jacek/inline-sidebar

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jacek created this revision.Aug 11 2022, 3:58 AM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptAug 11 2022, 3:58 AM

Harbormaster completed remote builds in B11297: Diff 15546.Aug 11 2022, 4:08 AM

• jacek requested review of this revision.Aug 11 2022, 4:08 AM

tomek accepted this revision.Aug 11 2022, 5:37 AM

This revision is now accepted and ready to land.Aug 11 2022, 5:37 AM

Does this have any visual effect (outside of fixing ENG-1591)?

• abosh accepted this revision.Aug 11 2022, 6:48 AM

In D4806#138759, @ashoat wrote:

Does this have any visual effect (outside of fixing ENG-1591)?

I didn't find any

• jacek added a child revision: D4825: [native] Introduce `inlineSidebar` animation when opening message tooltip to avoid visual issues..Aug 12 2022, 3:12 AM

• jacek removed a child revision: D4825: [native] Introduce `inlineSidebar` animation when opening message tooltip to avoid visual issues..

• jacek added a child revision: D4824: [native] Redesign `InlineSidebar` for reactions feature.Aug 12 2022, 3:14 AM

Closed by commit rCOMM0971b214372a: [native] Fix message tooltip positioning for robotext with sidebar (authored by • jacek). · Explain WhyAug 16 2022, 5:21 AM

This revision was automatically updated to reflect the committed changes.

• jacek added a commit: rCOMM0971b214372a: [native] Fix message tooltip positioning for robotext with sidebar.

Revision Contents
Changeset List

Path

Size

native/

chat/

robotext-message.react.js

2 lines

Diff 15546

native/chat/robotext-message.react.js

Loading...