Paths

Table of Contentst

[web] Use dispatchActionPromise when logging out
ClosedPublic
Actions

Authored by tomek on Aug 16 2022, 4:28 AM.

Tags

None

Referenced Files

	F3351587: D4847.id15712.diff
	Sat, Nov 23, 2:40 AM

	F3351584: D4847.id15645.diff
	Sat, Nov 23, 2:39 AM

	F3350627: D4847.diff
	Fri, Nov 22, 11:26 PM

	Unknown Object (File)
	Tue, Nov 5, 8:44 AM

	Unknown Object (File)
	Tue, Nov 5, 8:44 AM

	Unknown Object (File)
	Tue, Nov 5, 8:44 AM

	Unknown Object (File)
	Tue, Nov 5, 8:43 AM

	Unknown Object (File)
	Oct 10 2024, 4:41 AM

Subscribers

Details

Reviewers

• jacek
atul
ashoat

Commits

rCOMM5b9642aee34c: [web] Use dispatchActionPromise when logging out

Summary

Instead of calling server directly, we need to use dispatchActionPromise function, so that relevant redux actions are dispatched.
Fixes https://linear.app/comm/issue/ENG-1604/clean-enabled-apps-on-logout

Test Plan

Log out and check if logout success action was dispatched.

Diff Detail

Repository

rCOMM Comm

Branch

ENG-1604

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Aug 16 2022, 4:28 AM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptAug 16 2022, 4:28 AM

Harbormaster completed remote builds in B11376: Diff 15645.Aug 16 2022, 4:37 AM

tomek requested review of this revision.Aug 16 2022, 4:37 AM

tomek added a child revision: D4848: [lib] Clear enabled apps on logout.Aug 16 2022, 5:09 AM

ashoat accepted this revision.Aug 16 2022, 5:09 AM

This revision is now accepted and ready to land.Aug 16 2022, 5:09 AM

Closed by commit rCOMM5b9642aee34c: [web] Use dispatchActionPromise when logging out (authored by tomek). · Explain WhyAug 17 2022, 6:07 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM5b9642aee34c: [web] Use dispatchActionPromise when logging out.

Revision Contents
Changeset List

Path

Size

web/

settings/

account-settings.react.js

19 lines

Diff 15645

View Options

web/settings/account-settings.react.js

[web] Use dispatchActionPromise when logging outClosedPublicActions