Paths

Table of Contentst

Differential D4848

[lib] Clear enabled apps on logout
ClosedPublic
Actions

Authored by tomek on Aug 16 2022, 5:09 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jul 1, 7:20 PM

	Unknown Object (File)
	Mon, Jul 1, 9:16 AM

	Unknown Object (File)
	Mon, Jul 1, 3:15 AM

	Unknown Object (File)
	Mon, Jul 1, 2:51 AM

	Unknown Object (File)
	Mon, Jul 1, 1:48 AM

	Unknown Object (File)
	Mon, Jul 1, 12:26 AM

	Unknown Object (File)
	Sun, Jun 30, 2:30 PM

	Unknown Object (File)
	Fri, Jun 28, 11:16 PM

View All 65 Files

Subscribers

Details

Reviewers

• jacek
atul

Commits

rCOMMda6599eb4369: [lib] Clear enabled apps on logout

Summary

When a user is logged out we should clear enabled apps.

Fixes https://linear.app/comm/issue/ENG-1617/handle-logout-in-enabled-apps-reducer
Depends on D4847

Test Plan

native: set calendar as enabled, log out, log in and check if calendar is disabled.
web: tested as a part of D4812

Diff Detail

Repository

Branch

ENG-1604

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Aug 16 2022, 5:09 AM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptAug 16 2022, 5:09 AM

tomek added a child revision: D4812: [web] Persist enabled apps using default storage engine.Aug 16 2022, 5:09 AM

Harbormaster completed remote builds in B11377: Diff 15647.Aug 16 2022, 5:19 AM

tomek requested review of this revision.Aug 16 2022, 5:19 AM

Choose default apps based on platform

tomek planned changes to this revision.Aug 16 2022, 5:22 AM

tomek requested review of this revision.Aug 16 2022, 5:27 AM

tomek mentioned this in D4812: [web] Persist enabled apps using default storage engine.Aug 16 2022, 5:31 AM

Harbormaster completed remote builds in B11378: Diff 15649.Aug 16 2022, 5:31 AM

Looks good

lib/reducers/enabled-apps-reducer.js
35 ↗	(On Diff #15649)	Guessing you logged `process.env` on both `web` and `native` to ensure things were as expected.

This revision is now accepted and ready to land.Aug 16 2022, 2:01 PM

• abosh retitled this revision from [lib] Clear enabled aps on logout to [lib] Clear enabled apps on logout.Aug 16 2022, 2:06 PM

tomek added inline comments.Aug 17 2022, 5:52 AM

lib/reducers/enabled-apps-reducer.js
35 ↗	(On Diff #15649)	Yes, it is equal to `true` on web and `undefined` on native. This value is defined in `webpack/shared.cjs` and set in `createProdBrowserConfig` and `createDevBrowserConfig`.

Closed by commit rCOMMda6599eb4369: [lib] Clear enabled apps on logout (authored by tomek). · Explain WhyAug 17 2022, 6:07 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMda6599eb4369: [lib] Clear enabled apps on logout.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

enabled-apps-reducer.js

13 lines

Diff 15647

lib/reducers/enabled-apps-reducer.js

Loading...