Paths

Table of Contentst

Differential D4830

[CI] Add `yarn cleaninstall` via `nix develop` to Buildkite
ClosedPublic
Actions

Authored by atul on Aug 15 2022, 6:59 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 10, 6:26 AM

	Unknown Object (File)
	Sat, Nov 9, 12:02 PM

	Unknown Object (File)
	Sat, Nov 9, 12:02 PM

	Unknown Object (File)
	Sat, Nov 9, 12:02 PM

	Unknown Object (File)
	Sat, Nov 9, 12:02 PM

	Unknown Object (File)
	Tue, Nov 5, 2:08 AM

	Unknown Object (File)
	Oct 2 2024, 9:38 PM

	Unknown Object (File)
	Oct 2 2024, 9:38 PM

View All 94 Files

Subscribers

Details

Reviewers

• jon
varun
• abosh
tomek
• jacek

Commits

rCOMMa1c684ed2701: [CI] Add `yarn cleaninstall` via `nix develop` to Buildkite

Summary

Run yarn cleaninstall within nix environment and make sure it completes successfully.

Test Plan

Worked here:
https://buildkite.com/comm/nix-develop-darwin/builds/5#01824144-95d8-4952-b9c4-5500577c3ccb

Diff Detail

Repository

Branch

landaug16 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Aug 15 2022, 6:59 AM

Herald added subscribers: • adrian, ashoat. · View Herald TranscriptAug 15 2022, 6:59 AM

fix label

Harbormaster completed remote builds in B11348: Diff 15613.Aug 15 2022, 7:09 AM

Harbormaster completed remote builds in B11349: Diff 15614.

atul requested review of this revision.Aug 15 2022, 7:10 AM

Makes sense

.buildkite/nix_yarn.yml
2 ↗	(On Diff #15614)	a Buildkite emoji couldn't hurt...

This revision is now accepted and ready to land.Aug 15 2022, 7:39 AM

• jon requested changes to this revision.Aug 15 2022, 7:40 AM

• jon added inline comments.

.buildkite/nix_yarn.yml
5 ↗	(On Diff #15614)	I don't see this label on any of the agents, did you mean `mac=true`?

This revision now requires changes to proceed.Aug 15 2022, 7:40 AM

atul requested review of this revision.Aug 15 2022, 7:56 AM

atul added inline comments.

.buildkite/nix_yarn.yml
5 ↗	(On Diff #15614)	There's only one macOS agent running at the moment (MacBook Air with `mac=true`) because the Mac Minis were powered down for an office party on Friday (not ideal, I know). The 3 Mac minis have both `mac=true` and `nixdarwin=true`.

Oh, if it's just temporary, then that makes sense then

This revision is now accepted and ready to land.Aug 15 2022, 8:30 AM

In D4830#139623, @jon wrote:

Oh, if it's just temporary, then that makes sense then

Yeah, keeping the labels separate for now will probably just use mac=true going forward.

Just experimenting with per-device concurrency (running iOS builds and nix jobs on the same device at the same time)

atul added 1 blocking reviewer(s): varun.Aug 15 2022, 8:48 AM

This revision now requires review to proceed.Aug 15 2022, 8:48 AM

sounds good

varun accepted this revision.Aug 15 2022, 9:51 AM

This revision is now accepted and ready to land.Aug 15 2022, 9:51 AM

rebase before landing

This revision was landed with ongoing or failed builds.Aug 16 2022, 7:01 AM

Closed by commit rCOMMa1c684ed2701: [CI] Add `yarn cleaninstall` via `nix develop` to Buildkite (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMa1c684ed2701: [CI] Add `yarn cleaninstall` via `nix develop` to Buildkite.

Harbormaster completed remote builds in B11382: Diff 15658.Aug 16 2022, 7:10 AM

Revision Contents
Changeset List

Path

Size

.buildkite/

5 lines

Diff 15658

.buildkite/nix_yarn.yml

Loading...