[web] Replace `sidebar` and `reply` icon `MessageTooltip` with `CommIcon`
ClosedPublic
Actions

Authored by atul on Aug 17 2022, 10:35 AM.

Details

Reviewers

• abosh
varun
• jacek
tomek

Commits

rCOMM2819731c742c: [web] Replace `sidebar` and `reply` icon `MessageTooltip` with `CommIcon`

Summary

Searched through codebase for usages of message-circle-lines and reply-arrow and replaced them with sidebar-filled and reply-filled respectively.

Swapped out the SWMansion components for CommIcon components.

Test Plan

WARNING: Using the "filled" style of the sidebar and reply icon to match what we're doing on native.

Before:

Screen Shot 2022-08-17 at 1.35.53 PM.png (208×412 px, 14 KB)

After:

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Aug 17 2022, 10:35 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 17 2022, 10:35 AM

atul edited the test plan for this revision. (Show Details)Aug 17 2022, 10:36 AM

Harbormaster completed remote builds in B11427: Diff 15722.Aug 17 2022, 10:45 AM

atul requested review of this revision.Aug 17 2022, 10:45 AM

The filled versions look better in my opinion, so that’s awesome!

This revision is now accepted and ready to land.Aug 17 2022, 10:47 AM

atul added 1 blocking reviewer(s): varun.Aug 17 2022, 11:42 AM

This revision now requires review to proceed.Aug 17 2022, 11:42 AM

(cc @ashoat: not sure if it makes sense to add you as reviewer here, but just to make sure you see/sign off on the decision to match the icons on native)

varun accepted this revision.Aug 17 2022, 1:05 PM

This revision is now accepted and ready to land.Aug 17 2022, 1:05 PM

rebase before landing

This revision was landed with ongoing or failed builds.Aug 18 2022, 8:23 AM

Closed by commit rCOMM2819731c742c: [web] Replace `sidebar` and `reply` icon `MessageTooltip` with `CommIcon` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM2819731c742c: [web] Replace `sidebar` and `reply` icon `MessageTooltip` with `CommIcon`.

Harbormaster completed remote builds in B11443: Diff 15738.Aug 18 2022, 8:31 AM