Page MenuHomePhabricator
Differential D4928

[Nix] Fix corrosion logic when rustc is on PATH
ClosedPublic
Actions

Authored by • jon on Aug 23 2022, 12:39 PM.
Tags
None
Referenced Files
F3348758: D4928.id15896.diff
Fri, Nov 22, 3:59 PM
F3348748: D4928.id15885.diff
Fri, Nov 22, 3:58 PM
F3347307: D4928.diff
Fri, Nov 22, 11:49 AM
Unknown Object (File)
Thu, Nov 7, 1:28 AM
Unknown Object (File)
Tue, Nov 5, 2:06 AM
Unknown Object (File)
Oct 13 2024, 5:31 AM
Unknown Object (File)
Oct 12 2024, 2:50 PM
Unknown Object (File)
Oct 6 2024, 9:14 AM
View All 78 Files
Subscribers
• abosh
ashoat
tomek

Details

Reviewers
• max
atul
varun
• abosh
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rCOMM44de57ee0398: [Nix] Fix corrosion logic when rustc is on PATH
Summary

Having rustc on PATH makes corrosion assume
that it will be able to find cargo at the same
directory. This isn't true for nix.

The fix has been upstreamed to corrosion in
https://github.com/corrosion-rs/corrosion/pull/192
but there hasn't been a release since then.

Apply patch until a new release has been cut.

Depends on D4872

Test Plan
nix develop
cd services/tunnelbroker
rm -rf build && mkdir -p build && cd build && cmake .. && make -j

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jon created this revision.Aug 23 2022, 12:39 PM
Owners added a reviewer: Restricted Owners Package.Aug 23 2022, 12:39 PM
Herald added subscribers: • abosh, tomek, ashoat. · View Herald TranscriptAug 23 2022, 12:39 PM
• jon updated this revision to Diff 15885.Aug 23 2022, 12:43 PM

Minor comment correction

Harbormaster completed remote builds in B11550: Diff 15884.Aug 23 2022, 12:50 PM
Harbormaster completed remote builds in B11551: Diff 15885.Aug 23 2022, 12:54 PM
• jon requested review of this revision.Aug 23 2022, 12:54 PM
• jon added a reviewer: varun.Aug 23 2022, 1:19 PM
varun accepted this revision.Aug 23 2022, 1:24 PM
• abosh resigned from this revision.Aug 23 2022, 1:38 PM
• jon planned changes to this revision.Aug 23 2022, 1:50 PM

Added @varun to nix package owners so @abosh isn't a single bus factor

• jon requested review of this revision.Aug 23 2022, 1:50 PM
• jon added 1 blocking reviewer(s): varun.

sorry varun for re-ping but the owners logic needs you to be a owner before you accept the revision for it to count :(

varun accepted this revision.Aug 23 2022, 2:15 PM
This revision is now accepted and ready to land.Aug 23 2022, 2:15 PM
Closed by commit rCOMM44de57ee0398: [Nix] Fix corrosion logic when rustc is on PATH (authored by • jon). · Explain WhyAug 23 2022, 5:03 PM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMM44de57ee0398: [Nix] Fix corrosion logic when rustc is on PATH.

Revision Contents
Changeset List

PathSize
nix/
10 lines

Diff 15896

View Options

nix/overlay.nix

Loading...