[Native] Cleanup Tools/CMakeLists.txt
ClosedPublic
Actions

Authored by • jon on Aug 30 2022, 2:54 PM.

Details

Reviewers

atul
• abosh
• max

Commits

rCOMM466d95bd7b4c: [Native] Cleanup Tools/CMakeLists.txt

Summary

When adding the the CMakeLists.txt, I wasn't able to
reference the other sibling projects. This change is to remove
the target_include_directories entries in favor
of using target_link_library which is the more canonical way
to reference other projects now that they exist.

Depends on D4986

Test Plan

nix develop
cd native/cpp/CommonCpp
rm -rf build && mkdir build && cd build && cmake .. && make -j

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Aug 30 2022, 2:54 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 30 2022, 2:54 PM

• jon added a child revision: D4988: [Native] Cleanup grpc/CMakeLists.txt.Aug 30 2022, 2:55 PM

Harbormaster completed remote builds in B11727: Diff 16117.Aug 30 2022, 3:04 PM

• jon requested review of this revision.Aug 30 2022, 3:04 PM

cd native/cpp/CommonCpp

Guessing this was supposed to be native/cpp/CommonCpp/Tools?

Nice (assuming it was supposed to be within Tools)!

atuls-MacBook-Pro:build atul$ make -j
[ 50%] Building CXX object CMakeFiles/comm-tools.dir/WorkerThread.cpp.o
[100%] Linking CXX static library libcomm-tools.a
[100%] Built target comm-tools

This revision is now accepted and ready to land.Aug 30 2022, 3:21 PM

Nice (assuming it was supposed to be within Tools)!

CommonCpp was correct. The individual projects need to reference each other, and the parent directory is the correct place to do so. Tools just happens to be the only leaf.

Closed by commit rCOMM466d95bd7b4c: [Native] Cleanup Tools/CMakeLists.txt (authored by • jon). · Explain WhySep 2 2022, 3:22 PM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMM466d95bd7b4c: [Native] Cleanup Tools/CMakeLists.txt.