Differential D4988
[Native] Cleanup grpc/CMakeLists.txt Authored by • jon on Aug 30 2022, 2:55 PM. Tags None Referenced Files
Details
When adding the the CMakeLists.txt, I wasn't able to Depends on D4987 nix develop cd native/cpp/CommonCpp rm -rf build && mkdir build && cd build && cmake .. && make -j
Diff Detail
Event TimelineComment Actions -- Build files have been written to: /Users/atul/comm/native/cpp/CommonCpp/grpc/build
[ 18%] Generate protobuf files for blob
[ 18%] Generate protobuf files for tunnelbroker
[ 18%] Generate protobuf files for backup
[ 31%] Building CXX object CMakeFiles/comm-blob-grpc.dir/blob.grpc.pb.cc.o
[ 31%] Building CXX object CMakeFiles/comm-blob-grpc.dir/blob.pb.cc.o
[ 37%] Building CXX object CMakeFiles/comm-backup-grpc.dir/backup.grpc.pb.cc.o
[ 43%] Building CXX object CMakeFiles/comm-backup-grpc.dir/backup.pb.cc.o
[ 56%] Building CXX object CMakeFiles/comm-tunnelbroker-grpc.dir/tunnelbroker.grpc.pb.cc.o
[ 56%] Building CXX object CMakeFiles/comm-tunnelbroker-grpc.dir/tunnelbroker.pb.cc.o
[ 62%] Linking CXX static library libcomm-blob-grpc.a
[ 62%] Built target comm-blob-grpc
[ 68%] Linking CXX static library libcomm-tunnelbroker-grpc.a
[ 68%] Built target comm-tunnelbroker-grpc
[ 75%] Building CXX object CMakeFiles/comm-client.dir/ClientGetReadReactor.cpp.o
[ 87%] Building CXX object CMakeFiles/comm-client.dir/GRPCStreamHostObject.cpp.o
[ 87%] Building CXX object CMakeFiles/comm-client.dir/Client.cpp.o
In file included from /Users/atul/comm/native/cpp/CommonCpp/grpc/GRPCStreamHostObject.cpp:2:
In file included from /Users/atul/comm/native/cpp/CommonCpp/grpc/../NativeModules/InternalModules/GlobalNetworkSingleton.h:3:
/Users/atul/comm/native/cpp/CommonCpp/grpc/../NativeModules/InternalModules/../../Tools/WorkerThread.h:3:10: fatal error: 'folly/MPMCQueue.h' file not found
#include <folly/MPMCQueue.h>
^~~~~~~~~~~~~~~~~~~
[ 93%] Linking CXX static library libcomm-backup-grpc.a
[ 93%] Built target comm-backup-grpc
1 error generated.
make[2]: *** [CMakeFiles/comm-client.dir/GRPCStreamHostObject.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/comm-client.dir/all] Error 2
make: *** [all] Error 2Comment Actions
The purpose of this revisions is to remove grpc's knowledge of the responsibilities of the other projects. The grpc client doesn't use folly, native modules does. Please run the build from CommonCpp. CMake doesn't handle sibling dependencies well, and the canonical way to handle these scenarios is from the parent directory. I chose not to do the canonical thing originally because I would have had to package all of the projects under CommonCpp at the same time; and that would have been a hard no-go with the revision process we have. Copied from D4986:
|