Page MenuHomePhabricator

[web] Group usernames case insensitively in `MembersList`
ClosedPublic

Authored by abosh on Sep 1 2022, 1:36 AM.
Tags
None
Referenced Files
F3157145: D5000.id16156.diff
Tue, Nov 5, 7:25 PM
F3156894: D5000.diff
Tue, Nov 5, 5:52 PM
Unknown Object (File)
Sat, Nov 2, 1:15 PM
Unknown Object (File)
Sat, Nov 2, 1:15 PM
Unknown Object (File)
Sat, Nov 2, 1:12 PM
Unknown Object (File)
Wed, Oct 23, 10:04 AM
Unknown Object (File)
Wed, Oct 16, 11:34 PM
Unknown Object (File)
Oct 4 2024, 11:07 PM
Subscribers

Details

Summary

Related Linear issue here.

image.png (1×810 px, 67 KB)

Aboshcapital, aboshlocal, and Ashoatcapital's names all start with the letter A, but two groupings are created because the case is different. This diff merges the two groups together and groups member usernames case insensitively.

Test Plan

Tested on Chrome/Safari and works as expected.

Before:

image.png (1×810 px, 67 KB)

After:
image.png (1×918 px, 79 KB)

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

abosh edited the test plan for this revision. (Show Details)
abosh edited the summary of this revision. (Show Details)

good catch, wonder if there are any other places in the codebase where this is an issue

This revision is now accepted and ready to land.Sep 1 2022, 11:50 AM