Implement methods in SQLiteQueryExecutor and DatabaseQueryExecutor to store and retrieve current_user_id from SQLite
ClosedPublic
Actions

Authored by marcin on Aug 10 2022, 5:43 AM.

Details

Reviewers

tomek
• jon

Commits

rCOMM6de6e0ea396a: Implement methods in SQLiteQueryExecutor and DatabaseQueryExecutor to store and…

Summary

This differential defines in DatabaseQueryExecutor abstract class and implements in SQLiteQueryExecutor methods that insert and retrieve id of currently logged user in metadata table in SQLite. The method to retrieve user id will return empty string if there is no such row in metadata table.

Test Plan

Place those functions somewhere in AppDelegate, and place breakpoints where they are called. Build the app with database encryption disabled. Launch the app in the debugger, look at the SQLite database (accessible from terminal if using iOS simulator) before setCurrentUserID is called and afterwards. Ensure metadata table changes.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Aug 10 2022, 5:43 AM

Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptAug 10 2022, 5:43 AM

Add diff link to commit description

marcin added a parent revision: D4729: Introduce and implement 'clearSensitiveData' method in CommCoreModule.Aug 10 2022, 5:51 AM

marcin added a child revision: D4794: Implement methods to store and retrieve current_user_id from database in CommCoreModule.

Harbormaster completed remote builds in B11267: Diff 15504.Aug 10 2022, 5:54 AM

Harbormaster completed remote builds in B11269: Diff 15506.Aug 10 2022, 5:58 AM

marcin requested review of this revision.Aug 10 2022, 5:58 AM

ashoat added inline comments.Aug 10 2022, 6:59 AM

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
784–787 ↗	(On Diff #15506)	Is this really what `clang-format` wants? Is `clang-format` actually running here?

tomek accepted this revision.Aug 11 2022, 5:50 AM

This revision is now accepted and ready to land.Aug 11 2022, 5:50 AM

marcin added inline comments.Sep 5 2022, 4:26 AM

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
784–787 ↗	(On Diff #15506)	I always run `yarn clang-format-all` before updating/submitting a diff. This file (`SQliteQueryExecutor.cpp`) is returned by `get_clang_paths_cli.js` script which means it is not possible for this diff to pass phabricator CI if it was not formatted by clang.