[Services] Allow for tunnelbroker to receive command-line args
AbandonedPublic
Actions

Authored by • jon on Sep 12 2022, 10:25 PM.

Details

Reviewers

atul
• max
tomek
varun
• karol

Summary

To help with configuring services, we need a way to consume arguments
from the command line. This is an attempt to use the boost/program_options
component to achieve this. Since we already use boost, this doesn't add any
additional complexity to the build.

https://linear.app/comm/issue/ENG-1798

Test Plan

nix develop
cd services/tunnelbroker
rm -rf build && mkdir build && cd build && cmake .. && make -j
bin/tunnelbroker --help
# should see usage message

Diff Detail

Repository

rCOMM Comm

Branch

jonringer/tunnelbroker-args

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Sep 12 2022, 10:25 PM

Herald added subscribers: • abosh, ashoat. · View Herald TranscriptSep 12 2022, 10:25 PM

Remove debugging line

Harbormaster completed remote builds in B12105: Diff 16612.Sep 12 2022, 10:35 PM

Harbormaster completed remote builds in B12106: Diff 16613.

• jon requested review of this revision.Sep 12 2022, 10:36 PM

Tunnelbroker already has ConfigManager abstraction from which we are handling options. It uses boost::program_options as well as in your solution. I think we should use the current approach instead of parsing CLI elsewhere. In this case, we have a single point of truth for options and a single place where it resides.

This revision now requires changes to proceed.Sep 12 2022, 10:37 PM

Agreed, the current paradigm should be extended.

https://linear.app/comm/issue/ENG-1799/dont-immediate-fail-if-tunnelbrokerini-is-missing is the spiritual successor to this