Paths

Table of Contentst

Differential D5125

[Identity] Reference new proto location
ClosedPublic
Actions

Authored by • jon on Sep 13 2022, 10:31 AM.

Tags

None

Referenced Files

	F3121639: D5125.id16625.diff
	Fri, Nov 1, 8:31 AM

	F3121630: D5125.id16626.diff
	Fri, Nov 1, 8:28 AM

	F3120787: D5125.diff
	Fri, Nov 1, 6:27 AM

	Unknown Object (File)
	Thu, Oct 31, 6:54 AM

	Unknown Object (File)
	Thu, Oct 17, 3:28 PM

	Unknown Object (File)
	Thu, Oct 10, 8:27 AM

	Unknown Object (File)
	Tue, Oct 8, 1:15 AM

	Unknown Object (File)
	Tue, Oct 8, 1:15 AM

View All 86 Files

Subscribers

Details

Reviewers

varun
atul
• abosh
tomek

Commits

rCOMM9d0d1c31e451: [Identity] Reference new proto location

Summary

Update identity reference to new protobuf location.
Also update dockerfile to have a similar structure to the repo to avoid
issues around symlinking or other hacks to make the file present.

Test Plan

# Outside docker
nix develop # or install rust and protobuf 3.15 + grpc
cd services/identity
cargo test

# Docker
docker build . -f services/identity/Dockerfile

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Sep 13 2022, 10:31 AM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 13 2022, 10:31 AM

Harbormaster completed remote builds in B12117: Diff 16625.Sep 13 2022, 10:41 AM

• jon requested review of this revision.Sep 13 2022, 10:41 AM

Confirmed that things work as expected both inside Docker and outside Docker (via nix develop)

This revision is now accepted and ready to land.Sep 13 2022, 10:54 AM

Closed by commit rCOMM9d0d1c31e451: [Identity] Reference new proto location (authored by • jon). · Explain WhySep 13 2022, 11:13 AM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMM9d0d1c31e451: [Identity] Reference new proto location.

Revision Contents
Changeset List

Path

Size

services/

identity/

2 lines

2 lines

Diff 16626

services/identity/Dockerfile

Loading...

services/identity/build.rs

Loading...