Page MenuHomePhabricator
Differential D5151

[services] Tunnelbroker - Add device ping interval to Constants
ClosedPublic
Actions

Authored by • max on Sep 15 2022, 7:42 AM.
Tags
None
Referenced Files
F3386700: D5151.id16826.diff
Fri, Nov 29, 5:48 AM
Unknown Object (File)
Mon, Nov 25, 5:47 PM
Unknown Object (File)
Mon, Nov 25, 5:37 PM
Unknown Object (File)
Mon, Nov 25, 3:31 PM
Unknown Object (File)
Fri, Nov 22, 9:42 AM
Unknown Object (File)
Fri, Nov 22, 9:42 AM
Unknown Object (File)
Fri, Nov 22, 9:42 AM
Unknown Object (File)
Fri, Nov 22, 9:41 AM
View All Files
Subscribers
• abosh
ashoat
atul
• karol
tomek

Details

Reviewers
varun
tomek
• karol
ashoat
• jon
Commits
rCOMM6a8801a49786: [services] Tunnelbroker - Add device ping interval to Constants
Summary

This diff introduces a ping interval to check if the device is online.
The default "beacon" value for pinging is 3000 ms in our keyserver, which seems reasonable.
More context can be found in the Linear task.

Related Linear task: ENG-1766

Test Plan

No test, just a constant value.

Diff Detail

Repository
rCOMM Comm
Branch
add-constants-ping-interval
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• max created this revision.Sep 15 2022, 7:42 AM
• max held this revision as a draft.
Herald added a reviewer: • jon. · View Herald TranscriptSep 15 2022, 7:42 AM
Herald added subscribers: • abosh, • karol, atul and 2 others. · View Herald Transcript
• max published this revision for review.Sep 15 2022, 7:50 AM
• max edited the summary of this revision. (Show Details)
• max edited the test plan for this revision. (Show Details)
• max added reviewers: varun, tomek.
Herald added a reviewer: • karol. · View Herald TranscriptSep 15 2022, 7:51 AM
Harbormaster failed remote builds in B12173: Diff 16701!Sep 15 2022, 7:51 AM
Harbormaster completed remote builds in B12173: Diff 16701.Sep 15 2022, 8:00 AM
• max updated this revision to Diff 16702.Sep 15 2022, 8:13 AM

Change the interval to 3s accrording to our keyserver interval.

• max edited the summary of this revision. (Show Details)Sep 15 2022, 8:14 AM
Harbormaster completed remote builds in B12174: Diff 16702.Sep 15 2022, 8:23 AM
• jon resigned from this revision.Sep 15 2022, 4:24 PM

No context on correct path forward

ashoat accepted this revision.Sep 16 2022, 7:34 AM
tomek accepted this revision.Sep 19 2022, 5:31 AM
This revision is now accepted and ready to land.Sep 19 2022, 5:31 AM
Closed by commit rCOMM6a8801a49786: [services] Tunnelbroker - Add device ping interval to Constants (authored by • max). · Explain WhySep 19 2022, 5:37 AM
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMM6a8801a49786: [services] Tunnelbroker - Add device ping interval to Constants.
• max mentioned this in D5173: [services] Tunnelbroker - Update Protobuf file with the `ping`.Sep 19 2022, 6:32 AM
• max mentioned this in D5174: [services] Tunnelbroker - Add ping implementation to the `Get` handler.Sep 19 2022, 6:35 AM
• max mentioned this in rCOMMbf9ad730ef50: [services] Tunnelbroker - Update Protobuf file with the `ping`.Sep 21 2022, 2:29 PM
• max mentioned this in rCOMM5d2497b42072: [services] Tunnelbroker - Add ping implementation to the `Get` handler.Sep 23 2022, 1:51 PM

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
1 line

Diff 16701

View Options

services/tunnelbroker/src/Constants.h

Loading...