Page MenuHomePhabricator

[Backup] Add logging to blob_client
ClosedPublic

Authored by jon on Sep 12 2022, 3:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 27, 6:36 PM
Unknown Object (File)
Sun, Oct 27, 6:36 PM
Unknown Object (File)
Sun, Oct 27, 6:36 PM
Unknown Object (File)
Sun, Oct 27, 6:35 PM
Unknown Object (File)
Mon, Oct 21, 11:06 PM
Unknown Object (File)
Oct 15 2024, 8:30 AM
Unknown Object (File)
Oct 8 2024, 1:15 AM
Unknown Object (File)
Oct 8 2024, 1:15 AM
Subscribers

Details

Summary

Add logging crates to backup. This will allow for tracing commands
to work.

Part of https://linear.app/comm/issue/ENG-1717

Test Plan

Backup CI gate

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul added 1 blocking reviewer(s): ashoat.

Looks good to me. Might've been helpful to link respective repos when adding dependencies:

env_logger: https://github.com/env-logger-rs/env_logger/
log: https://github.com/rust-lang/log


Adding @ashoat as blocking since dependency diff.

In addition to that:

There is a bit of awkwardness, in that most log implementations assume you initialize it from a main.rs, but we really don't have one since it's currently a library extending C++

This revision is now accepted and ready to land.Sep 15 2022, 7:19 PM

Nice catch @jon ! I should add env_logger to the Tunnelbroker Rust lib as well.

This revision was automatically updated to reflect the committed changes.