Page MenuHomePhabricator
Differential D5194

[CI] Auto-accept flake config
ClosedPublic
Actions

Authored by • jon on Sep 20 2022, 8:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 15, 8:35 PM
Unknown Object (File)
Wed, Apr 9, 1:13 AM
Unknown Object (File)
Wed, Apr 9, 1:12 AM
Unknown Object (File)
Wed, Apr 9, 1:12 AM
Unknown Object (File)
Wed, Apr 9, 1:12 AM
Unknown Object (File)
Mar 21 2025, 3:35 AM
Unknown Object (File)
Mar 19 2025, 7:32 PM
Unknown Object (File)
Mar 18 2025, 8:53 PM
View All Files
Subscribers
tomek

Details

Reviewers
atul
ashoat
• abosh
varun
Commits
rCOMMdd3b8d29408e: [CI] Auto-accept flake config
Summary

Nix by default only polls for user input when confirming the values,
in a CI environment there's no way to progress the builds without passing
the '--accept-flake-config' value explicitly.

See: https://github.com/NixOS/nix/issues/7071

Test Plan

https://buildkite.com/comm/tunnelbroker-unit-tests/builds/50#01835b9d-1109-4c97-9c3a-444f70fb6a82 passes

Diff Detail

Repository
rCOMM Comm
Branch
jonringer/accept-flake-config
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
.buildkite/
2 lines
2 lines
2 lines

Diff 16916

View Options

.buildkite/identity_tests.yml

// @flow // @flow
import Alert from 'react-native/Libraries/Alert/Alert.js'; import Alert from 'react-native/Libraries/Alert/Alert.js';
function exitEditAlert(onDiscard: () => void): void { function exitEditAlert(onDiscard: () => void, onPress: ?() => void): void {
Alert.alert( Alert.alert(
'Discard changes?', 'Discard changes?',
'You have unsaved changes which will be discarded if you navigate away.', 'You have unsaved changes which will be discarded if you navigate away.',
[ [
{ {
text: 'Continue editing', text: 'Continue editing',
style: 'cancel', style: 'cancel',
onPress: onPress,
tomekUnsubmitted
Not Done
Inline Actions
import Alert from 'react-native/Libraries/Alert/Alert.js';
- function exitEditAlert(onDiscard: () => void, onPress: ?() => void): void {
+ function exitEditAlert(onDiscard: () => void, onContinueEditing: ?() => void): void {
Alert.alert(
'Discard changes?',
'You have unsaved changes which will be discarded if you navigate away.',
[
{
text: 'Continue editing',
style: 'cancel',
- onPress: onPress,
+ onPress: onContinueEditing,
},
{
text: 'Discard edit',

Maybe we should be more explicit in naming these

tomek: Maybe we should be more explicit in naming these
}, },
{ {
text: 'Discard edit', text: 'Discard edit',
style: 'destructive', style: 'destructive',
onPress: () => { onPress: onDiscard,
onDiscard();
},
}, },
], ],
); );
} }
export { exitEditAlert }; export { exitEditAlert };
View Options

.buildkite/nix_yarn.yml

// @flow // @flow
import Alert from 'react-native/Libraries/Alert/Alert.js'; import Alert from 'react-native/Libraries/Alert/Alert.js';
function exitEditAlert(onDiscard: () => void): void { function exitEditAlert(onDiscard: () => void, onPress: ?() => void): void {
Alert.alert( Alert.alert(
'Discard changes?', 'Discard changes?',
'You have unsaved changes which will be discarded if you navigate away.', 'You have unsaved changes which will be discarded if you navigate away.',
[ [
{ {
text: 'Continue editing', text: 'Continue editing',
style: 'cancel', style: 'cancel',
onPress: onPress,
tomekUnsubmitted
Not Done
Inline Actions
import Alert from 'react-native/Libraries/Alert/Alert.js';
- function exitEditAlert(onDiscard: () => void, onPress: ?() => void): void {
+ function exitEditAlert(onDiscard: () => void, onContinueEditing: ?() => void): void {
Alert.alert(
'Discard changes?',
'You have unsaved changes which will be discarded if you navigate away.',
[
{
text: 'Continue editing',
style: 'cancel',
- onPress: onPress,
+ onPress: onContinueEditing,
},
{
text: 'Discard edit',

Maybe we should be more explicit in naming these

tomek: Maybe we should be more explicit in naming these
}, },
{ {
text: 'Discard edit', text: 'Discard edit',
style: 'destructive', style: 'destructive',
onPress: () => { onPress: onDiscard,
onDiscard();
},
}, },
], ],
); );
} }
export { exitEditAlert }; export { exitEditAlert };
View Options

.buildkite/tunnelbroker_unittests.yml

// @flow // @flow
import Alert from 'react-native/Libraries/Alert/Alert.js'; import Alert from 'react-native/Libraries/Alert/Alert.js';
function exitEditAlert(onDiscard: () => void): void { function exitEditAlert(onDiscard: () => void, onPress: ?() => void): void {
Alert.alert( Alert.alert(
'Discard changes?', 'Discard changes?',
'You have unsaved changes which will be discarded if you navigate away.', 'You have unsaved changes which will be discarded if you navigate away.',
[ [
{ {
text: 'Continue editing', text: 'Continue editing',
style: 'cancel', style: 'cancel',
onPress: onPress,
tomekUnsubmitted
Not Done
Inline Actions
import Alert from 'react-native/Libraries/Alert/Alert.js';
- function exitEditAlert(onDiscard: () => void, onPress: ?() => void): void {
+ function exitEditAlert(onDiscard: () => void, onContinueEditing: ?() => void): void {
Alert.alert(
'Discard changes?',
'You have unsaved changes which will be discarded if you navigate away.',
[
{
text: 'Continue editing',
style: 'cancel',
- onPress: onPress,
+ onPress: onContinueEditing,
},
{
text: 'Discard edit',

Maybe we should be more explicit in naming these

tomek: Maybe we should be more explicit in naming these
}, },
{ {
text: 'Discard edit', text: 'Discard edit',
style: 'destructive', style: 'destructive',
onPress: () => { onPress: onDiscard,
onDiscard();
},
}, },
], ],
); );
} }
export { exitEditAlert }; export { exitEditAlert };