[web] Change See More... hover color to match chat threads hover color
ClosedPublic
Actions

Authored by rohan on Sep 16 2022, 10:44 AM.

Details

Reviewers

atul
varun

Commits

rCOMM9a3db8380f51: [web] Change See More... hover color to match chat threads hover color

Summary

Changed the div.thread class's hover color to match the hover color of the
activeThread, since var(--thread-active-bg) is a different shade from
var(--thread-hover-bg).

The difference is shown in the themes.css file:

--thread-hover-bg: var(--shades-black-90);
--thread-active-bg: var(--shades-black-80);

Test Plan

Ran the before and after versions of this change and visually
the colors are the same with this change.

Before:

Screen Shot 2022-09-16 at 1.46.50 PM.png (422×802 px, 37 KB)

After:

Screen Shot 2022-09-16 at 1.46.13 PM.png (402×810 px, 36 KB)

For a closer look at the change in the thread color:

Before:

Screen Shot 2022-09-16 at 2.10.01 PM.png (410×816 px, 36 KB)

After:

Screen Shot 2022-09-16 at 2.09.50 PM.png (440×812 px, 37 KB)

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D5162

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

rohan created this revision.Sep 16 2022, 10:44 AM

Herald added subscribers: • abosh, tomek, ashoat. · View Herald TranscriptSep 16 2022, 10:44 AM

rohan edited the test plan for this revision. (Show Details)Sep 16 2022, 10:47 AM

rohan edited the summary of this revision. (Show Details)

rohan attached a referenced file: F171815: Screen Shot 2022-09-16 at 1.46.13 PM.png. (Show Details)

rohan attached a referenced file: F171814: Screen Shot 2022-09-16 at 1.46.50 PM.png. (Show Details)Sep 16 2022, 10:49 AM

Harbormaster completed remote builds in B12222: Diff 16770.Sep 16 2022, 10:54 AM

rohan requested review of this revision.Sep 16 2022, 10:54 AM

rohan edited the test plan for this revision. (Show Details)Sep 16 2022, 11:11 AM

rohan attached a referenced file: F171864: Screen Shot 2022-09-16 at 2.10.01 PM.png. (Show Details)

rohan attached a referenced file: F171865: Screen Shot 2022-09-16 at 2.09.50 PM.png. (Show Details)

resolves https://linear.app/comm/issue/ENG-1462/consistent-hover-state-for-sidebar-list-in-web-inbox

I don't think we should be changing the background for div.thread:hover selector from --thread-hover-bg (which based on the name is clearly the right variable) to --thread-active-bg.

There are no other usages of --thread-hover-bg so if anything we should be changing the value in theme.css.

Can you take another look to see if there's a better approach here?

This revision now requires changes to proceed.Sep 21 2022, 7:33 AM

Sure, that makes sense. For the reason that --thread-hover-bg isn't used anywhere else I thought it made sense just to change the background from --thread-hover-bg to --thread-active-bg. Though I agree that it makes sense to change --thread-hover-bg directly in theme.css.

Updating D5162: [web] Change See More... hover color to match chat threads hover color #
Enter a brief description of the changes included in this update.
The first line is used as subject, next lines as comment.

Revision to update themes.css file
Updates the theme.css file for the --thread-hover-bg value instead of changing the css corresponding to the element.