ENG-1875
If you start creating a new chat and don't add any people the title will display your name and clicking it will navigate you to your private chat's settings. This happens because Ashoat is added to every chat be default and the isSearchEmpty is always false.
Details
Details
Start creating a new chat and don't select any other users, title should be "New Message". Also, test as Ashoat.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- eng1875
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/chat/message-list-header-title.react.js | ||
|---|---|---|
| 29 ↗ | (On Diff #17021) | Won't this break the experience for me? I think this.props.threadInfo.members.length === 1 for me... |
| native/chat/message-list-header-title.react.js | ||
|---|---|---|
| 29 ↗ | (On Diff #17021) | Yeah, @varun solved this as his second task on the project actually (D2546). I think we should first extract that functionality into a separate function you can reuse, and then you can use it here. We should also consider how this works on web... does it have the same problem? |
Comment Actions
Updated the diff to use extracted method (I'm not sure if threadMembersWithoutAddedAshoat is a good name but I couldn't think of a better one...), thanks for the help!
Also, would it be better to do this in a separate diff? I'm still not sure when should I split things into other diffs.
Comment Actions
Looks great! Please address the following two comments before landing:
- Can you amend the test plan to include testing the app as me to make sure this doesn't break my experience? The reason is that I'm unclear as to whether I would end up being filtered out of a pending thread when I am the viewer. (I assume I have a member.role in that scenario, but I am not sure.)
- Can you update ENG-281 to cover the changes introduced here? You should probably change the title, and amend the description to cover both the history (eg. intial use case, and then this use case, with diffs linked) as well as what needs to be done (threadMembersWithoutAddedAshoat should be deprecated).
Comment Actions
Additional info to the previous comment: it doesn't happen on web because when there are no users selected, the search fills the whole screen and no title is displayed.