[web] Clear error message during switching between tabs in `ThreadSettingsModal`
ClosedPublic
Actions

Authored by • jakub on Sep 23 2022, 2:29 PM.

Details

Reviewers

tomek
atul

Commits

rCOMMbbd050c98ab3: [web] Clear error message during switching between tabs in `ThreadSettingsModal`

Summary

Depends on D5220

Improving UX of the ThreadSettingsModal

Main change:

clear error message when current active tab changes

Test Plan

Go to any chat
Go to Thread Menu > Settings (ThreadSettingsModal)
Trigger any error (e.g. type wrong password in Delete tab)
Switch to another tab

Now error message disappear

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jakub created this revision.Sep 23 2022, 2:29 PM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptSep 23 2022, 2:29 PM

Harbormaster completed remote builds in B12409: Diff 17028.Sep 23 2022, 2:39 PM

• jakub requested review of this revision.Sep 23 2022, 2:39 PM

• jakub edited the summary of this revision. (Show Details)Sep 23 2022, 2:46 PM

• jakub edited the test plan for this revision. (Show Details)

• jakub added reviewers: tomek, atul.

• jakub added a parent revision: D5220: [web] Keep submit buttons always on the bottom of the `ThreadSettingsModal`.

Based on the video you provided, should we also gray out the Delete button in the Delete tab if the password input field is empty?

In D5222#153960, @atul wrote:

Based on the video you provided, should we also gray out the Delete button in the Delete tab if the password input field is empty?

Yeah, sounds like a good idea. We should create a new task for it and implement it when appropriate. @jakub could you create a task?

web/modals/threads/settings/thread-settings-modal.react.js
127 ↗	(On Diff #17028)	For me it would make a little more sense to clear on exit instead of enter

This revision is now accepted and ready to land.Sep 27 2022, 11:50 AM

Adjust to code review and rebase

In D5222#154090, @tomek wrote:

In D5222#153960, @atul wrote:

Based on the video you provided, should we also gray out the Delete button in the Delete tab if the password input field is empty?

Yeah, sounds like a good idea. We should create a new task for it and implement it when appropriate. @jakub could you create a task?