Page MenuHomePhabricator
Differential D5222

[web] Clear error message during switching between tabs in `ThreadSettingsModal`
ClosedPublic
Actions

Authored by • jakub on Sep 23 2022, 7:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 7:39 PM
Unknown Object (File)
Sat, Nov 9, 7:39 PM
Unknown Object (File)
Sat, Nov 9, 7:39 PM
Unknown Object (File)
Sat, Nov 9, 7:39 PM
Unknown Object (File)
Sat, Nov 9, 7:35 PM
Unknown Object (File)
Tue, Nov 5, 2:07 AM
Unknown Object (File)
Oct 13 2024, 12:05 PM
Unknown Object (File)
Oct 13 2024, 12:05 PM
View All Files
Subscribers
• abosh
ashoat
atul
tomek

Details

Reviewers
tomek
atul
Commits
rCOMMbbd050c98ab3: [web] Clear error message during switching between tabs in `ThreadSettingsModal`
Summary

Depends on D5220

Improving UX of the ThreadSettingsModal

Main change:

  • clear error message when current active tab changes

Test Plan
  1. Go to any chat
  2. Go to Thread Menu > Settings (ThreadSettingsModal)
  3. Trigger any error (e.g. type wrong password in Delete tab)
  4. Switch to another tab

Now error message disappear

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jakub created this revision.Sep 23 2022, 7:29 AM
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptSep 23 2022, 7:29 AM
Harbormaster completed remote builds in B12409: Diff 17028.Sep 23 2022, 7:39 AM
• jakub requested review of this revision.Sep 23 2022, 7:39 AM
• jakub edited the summary of this revision. (Show Details)Sep 23 2022, 7:46 AM
• jakub edited the test plan for this revision. (Show Details)
• jakub added reviewers: tomek, atul.
• jakub added a parent revision: D5220: [web] Keep submit buttons always on the bottom of the `ThreadSettingsModal`.
atul accepted this revision.Sep 26 2022, 1:17 PM
atul added 1 blocking reviewer(s): tomek.

Based on the video you provided, should we also gray out the Delete button in the Delete tab if the password input field is empty?

tomek accepted this revision.Sep 27 2022, 4:50 AM
In D5222#153960, @atul wrote:

Based on the video you provided, should we also gray out the Delete button in the Delete tab if the password input field is empty?

Yeah, sounds like a good idea. We should create a new task for it and implement it when appropriate. @jakub could you create a task?

web/modals/threads/settings/thread-settings-modal.react.js
127 ↗(On Diff #17028)

For me it would make a little more sense to clear on exit instead of enter

This revision is now accepted and ready to land.Sep 27 2022, 4:50 AM
• jakub updated this revision to Diff 17144.Sep 28 2022, 4:03 AM

Adjust to code review and rebase

• jakub added a comment.Sep 28 2022, 4:06 AM
In D5222#154090, @tomek wrote:
In D5222#153960, @atul wrote:

Based on the video you provided, should we also gray out the Delete button in the Delete tab if the password input field is empty?

Yeah, sounds like a good idea. We should create a new task for it and implement it when appropriate. @jakub could you create a task?

Sure, I've just created it: link

Harbormaster completed remote builds in B12490: Diff 17144.Sep 28 2022, 4:14 AM
• jakub updated this revision to Diff 17234.Sep 30 2022, 5:49 AM

Rebase before landing

Harbormaster completed remote builds in B12555: Diff 17234.Sep 30 2022, 5:59 AM
Closed by commit rCOMMbbd050c98ab3: [web] Clear error message during switching between tabs in `ThreadSettingsModal` (authored by • jakub). · Explain WhySep 30 2022, 6:01 AM
This revision was automatically updated to reflect the committed changes.
• jakub added a commit: rCOMMbbd050c98ab3: [web] Clear error message during switching between tabs in `ThreadSettingsModal`.

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
settings/
2 lines

Diff 17234

View Options

web/modals/threads/settings/thread-settings-modal.react.js

Loading...