Page MenuHomePhabricator

[services] Provision EC2 Instances for remaining services with Terraform
AbandonedPublic

Authored by varun on Sep 30 2022, 8:00 AM.
Tags
None
Referenced Files
F3509071: D5270.diff
Sat, Dec 21, 12:51 AM
Unknown Object (File)
Tue, Dec 17, 6:49 AM
Unknown Object (File)
Tue, Dec 17, 6:48 AM
Unknown Object (File)
Tue, Dec 17, 6:47 AM
Unknown Object (File)
Tue, Nov 26, 3:23 PM
Unknown Object (File)
Sun, Nov 24, 12:23 PM
Unknown Object (File)
Nov 20 2024, 10:50 AM
Unknown Object (File)
Oct 29 2024, 8:23 PM

Details

Reviewers
jon
atul
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

Essentially the same as the previous diff in the stack, but for the other three services.

Depends on D5269

Test Plan

terraform validate && terraform plan

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun requested review of this revision.Sep 30 2022, 8:11 AM
atul requested changes to this revision.Sep 30 2022, 8:33 AM

Same feedback as D5269:

At a high level this looks good but

A. I don't have terraform installed. It doesn't seem like it is part of the nix environment yet. We should at least create a task for that before landing (CC @jon)

atuls-MacBook-Pro:comm atul$ terraform validate && terraform plan
bash: terraform: command not found

B. Can you go into more detail in the Test Plan. Right now, even after installing terraform, I get the following:

│ Error: No configuration files
│ 
│ Plan requires configuration to be present. Planning without a configuration
│ would mark everything for destruction, which is normally not what is desired.
│ If you would like to destroy everything, run plan with the -destroy option.
│ Otherwise, create a Terraform configuration file (.tf file) and try again.

Is there a certain directory that it needs to be run in?

This revision now requires changes to proceed.Sep 30 2022, 8:33 AM

you might also need aws credentials. i'll update the test plan now

We should at least create a task for that before landing (CC @jon)

https://linear.app/comm/issue/ENG-1997/add-terraform-to-nix-environment, D5336 landed super quick!!