Page MenuHomePhabricator
Differential D5275

[Nix docs] Correct port for web workflow
ClosedPublic
Actions

Authored by • jon on Sep 30 2022, 2:28 PM.
Tags
None
Referenced Files
F3398699: D5275.id17257.diff
Mon, Dec 2, 12:06 AM
F3398631: D5275.id17551.diff
Sun, Dec 1, 11:45 PM
F3398451: D5275.id17901.diff
Sun, Dec 1, 11:03 PM
F3398424: D5275.id17850.diff
Sun, Dec 1, 10:53 PM
F3398116: D5275.diff
Sun, Dec 1, 9:05 PM
F3397850: D5275.id17901.diff
Sun, Dec 1, 7:43 PM
Unknown Object (File)
Mon, Nov 25, 10:29 PM
Unknown Object (File)
Mon, Nov 25, 10:29 PM
View All Files
Subscribers
tomek

Details

Reviewers
ashoat
varun
atul
• abosh
Commits
rCOMM7cd7f8de5f85: [Nix docs] Correct port for web workflow
Summary

Update docs to point to correct url. Since the nix worklfow isn't
using a service like apache to pass through port 80 traffic, using the default
http port won't work.

Test Plan

N/A

Diff Detail

Repository
rCOMM Comm
Branch
jonringer/generate-urls
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Sep 30 2022, 2:28 PM
Herald added a subscriber: tomek. · View Herald TranscriptSep 30 2022, 2:28 PM
• jon added a parent revision: D5274: [Nix] Auto-generate url json configuration files.Sep 30 2022, 2:28 PM
Harbormaster completed remote builds in B12569: Diff 17257.Sep 30 2022, 2:38 PM
• jon requested review of this revision.Sep 30 2022, 2:38 PM
ashoat requested changes to this revision.Oct 1 2022, 3:54 AM
ashoat added inline comments.
docs/nix_web_workflows.md
45

Here

This revision now requires changes to proceed.Oct 1 2022, 3:54 AM
• jon planned changes to this revision.Oct 5 2022, 10:38 AM

Probably need to pair with someone to assert that this is working from a clean state.

• jon updated this revision to Diff 17551.Oct 13 2022, 11:25 AM

Rebase on master

Harbormaster completed remote builds in B12779: Diff 17551.Oct 13 2022, 11:37 AM
atul requested changes to this revision.Oct 13 2022, 1:13 PM

Update line 45 and I think this will be good to land

This revision now requires changes to proceed.Oct 13 2022, 1:13 PM
• jon updated this revision to Diff 17850.Oct 24 2022, 7:37 AM

Correct other usage of http://localhost

• jon marked an inline comment as done.Oct 24 2022, 7:37 AM
Harbormaster completed remote builds in B12991: Diff 17850.Oct 24 2022, 7:49 AM
ashoat accepted this revision.Oct 24 2022, 8:00 AM
atul accepted this revision.Oct 24 2022, 8:56 AM
This revision is now accepted and ready to land.Oct 24 2022, 8:56 AM
Closed by commit rCOMM7cd7f8de5f85: [Nix docs] Correct port for web workflow (authored by • jon). · Explain WhyOct 25 2022, 10:21 AM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMM7cd7f8de5f85: [Nix docs] Correct port for web workflow.

Revision Contents
Changeset List

PathSize
docs/
2 lines

Diff 17257

View Options

docs/nix_web_workflows.md

Loading...