Page MenuHomePhabricator
Differential D5246

[Nix] Add localstack-down
ClosedPublic
Actions

Authored by • jon on Sep 27 2022, 9:42 PM.
Tags
None
Referenced Files
F3509298: D5246.diff
Sat, Dec 21, 3:15 AM
Unknown Object (File)
Wed, Nov 27, 5:22 AM
Unknown Object (File)
Mon, Nov 25, 10:21 PM
Unknown Object (File)
Mon, Nov 25, 10:21 PM
Unknown Object (File)
Mon, Nov 25, 10:21 PM
Unknown Object (File)
Mon, Nov 25, 7:54 PM
Unknown Object (File)
Sun, Nov 24, 12:10 PM
Unknown Object (File)
Fri, Nov 22, 8:00 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
• abosh
varun
ashoat
atul
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rCOMMafb91bc1e417: [Nix] Add localstack-down
Summary

Allow for localstack to be easily be shutdown through nix

part of: https://linear.app/comm/issue/ENG-1697

Depends on D5245

Test Plan
nix run .#localstack-up
# get message about it being up
docker ps # assert localstack is running

nix run .#localstack-down
docker ps # assert localstack is no longer running

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Sep 27 2022, 9:42 PM
Owners added a reviewer: Restricted Owners Package.Sep 27 2022, 9:42 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 27 2022, 9:42 PM
Harbormaster completed remote builds in B12478: Diff 17125.Sep 27 2022, 9:52 PM
• jon requested review of this revision.Sep 27 2022, 9:52 PM
atul resigned from this revision.Sep 28 2022, 11:13 AM
atul added 1 blocking reviewer(s): • abosh.

Resigning and adding @abosh as blocking. Anticipate you'll get some pushback on shell within writeShellApplication instead of external file

• jon updated this revision to Diff 17366.Oct 5 2022, 10:29 AM

Refactor into script and nix wrapper

Harbormaster completed remote builds in B12636: Diff 17366.Oct 5 2022, 10:39 AM
• jon mentioned this in D5304: [Docs] Update tunnelbroker configuration section.Oct 5 2022, 11:07 AM
• jon added a child revision: D5304: [Docs] Update tunnelbroker configuration section.Oct 5 2022, 11:08 AM
ashoat removed 1 blocking reviewer(s): • abosh.Oct 6 2022, 5:51 AM

@abosh is busy with classwork

ashoat requested changes to this revision.Oct 6 2022, 5:52 AM

Looks great, requesting changes for minor nits

scripts/localstack_down.sh
15 ↗(On Diff #17366)

Typo here

18 ↗(On Diff #17366)

Can we capitalize "No" for consistency?

This revision now requires changes to proceed.Oct 6 2022, 5:52 AM
• jon updated this revision to Diff 17392.Oct 6 2022, 11:39 AM
• jon marked 2 inline comments as done.

Fix typos

scripts/localstack_down.sh
18 ↗(On Diff #17366)

Yep

Harbormaster completed remote builds in B12658: Diff 17392.Oct 6 2022, 11:50 AM
ashoat accepted this revision.Oct 6 2022, 1:50 PM
• jon added 1 blocking reviewer(s): varun.Oct 7 2022, 2:14 PM
varun accepted this revision.Oct 10 2022, 12:09 PM
This revision is now accepted and ready to land.Oct 10 2022, 12:09 PM
Closed by commit rCOMMafb91bc1e417: [Nix] Add localstack-down (authored by • jon). · Explain WhyOct 10 2022, 3:06 PM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMMafb91bc1e417: [Nix] Add localstack-down.

Revision Contents
Changeset List

PathSize
nix/
11 lines
3 lines
scripts/
19 lines

Diff 17392

View Options

nix/localstack-down.nix

Loading...
View Options

nix/overlay.nix

Loading...
View Options

scripts/localstack_down.sh

Loading...