Page MenuHomePhabricator
Differential D5304

[Docs] Update tunnelbroker configuration section
ClosedPublic
Actions

Authored by • jon on Oct 5 2022, 11:07 AM.
Tags
None
Referenced Files
F3509459: D5304.id17368.diff
Sat, Dec 21, 5:12 AM
Unknown Object (File)
Tue, Nov 26, 5:02 PM
Unknown Object (File)
Tue, Nov 26, 5:02 PM
Unknown Object (File)
Tue, Nov 26, 5:02 PM
Unknown Object (File)
Tue, Nov 26, 5:02 PM
Unknown Object (File)
Sun, Nov 24, 2:42 PM
Unknown Object (File)
Fri, Nov 22, 8:00 AM
Unknown Object (File)
Fri, Nov 22, 8:00 AM
View All Files
Subscribers
• abosh
atul

Details

Reviewers
• max
tomek
ashoat
varun
Commits
rCOMM6193b9635fbf: [Docs] Update tunnelbroker configuration section
Summary

Update tunnelbroker docs to reflect new state-of-the-world, in that
it requires a default keyserver now.

Add configuration files to .gitignore to avoid developers clobbering each
others dev environments.

Requirement added in https://phab.comm.dev/D2903

https://linear.app/comm/issue/ENG-1971

Depends on D5246

Test Plan

N/A

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jon created this revision.Oct 5 2022, 11:07 AM
Herald added subscribers: • abosh, atul. · View Herald TranscriptOct 5 2022, 11:07 AM
• jon edited the summary of this revision. (Show Details)Oct 5 2022, 11:08 AM
• jon added a parent revision: D5246: [Nix] Add localstack-down.
• jon updated this revision to Diff 17368.Oct 5 2022, 11:15 AM

Correct installation directions

• jon added a comment.Oct 5 2022, 11:16 AM

https://phab.comm.dev/D2903 also made $HOME/tunnelbroker/tunnelbroker.ini the configuration path.

Harbormaster completed remote builds in B12637: Diff 17367.Oct 5 2022, 11:18 AM
Harbormaster completed remote builds in B12638: Diff 17368.Oct 5 2022, 11:25 AM
• jon requested review of this revision.Oct 5 2022, 11:25 AM
ashoat accepted this revision.Oct 6 2022, 5:56 AM
ashoat added 1 blocking reviewer(s): • max.

This makes sense to me, but @max should take a look. (Might take a sec since he's on a trip)

• max accepted this revision.Oct 6 2022, 6:14 AM

Git-ignoring the tunnelbroker.ini looks reasonable to me, as well as updating the docs reflecting what the configuration file must contain. Thanks, @jon !

This revision is now accepted and ready to land.Oct 6 2022, 6:14 AM
Closed by commit rCOMM6193b9635fbf: [Docs] Update tunnelbroker configuration section (authored by • jon). · Explain WhyOct 10 2022, 3:06 PM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMM6193b9635fbf: [Docs] Update tunnelbroker configuration section.

Revision Contents
Changeset List

PathSize
1 line
docs/
6 lines
services/
tunnelbroker/

Diff 17473

View Options

.gitignore

Loading...
View Options

docs/dev_services.md

Loading...
View Options

services/tunnelbroker/tunnelbroker.ini

Loading...