[landing] added learn more about comm link to footer
ClosedPublic
Actions

Authored by ginsu on Oct 11 2022, 1:31 PM.

Details

Reviewers

atul
rohan
• abosh

Commits

rCOMM3a908c7a5896: [landing] added learn more about comm link to footer

Summary

Won't land this until the Team Listing part of comm.page has been updated

added learn more about comm link to footer.

Test Plan

Please view the before and after demo to see the changes I made:

Before:

Screen Shot 2022-10-11 at 4.21.37 PM.png (2×3 px, 1 MB)

After:

With margin instead of space:

Screen Shot 2022-10-12 at 11.51.04 AM.png (2×3 px, 1 MB)

Diff Detail

Repository

rCOMM Comm

Branch

eng-1655

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Oct 11 2022, 1:31 PM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptOct 11 2022, 1:31 PM

ginsu edited the summary of this revision. (Show Details)Oct 11 2022, 1:33 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, rohan, • abosh.

ginsu attached a referenced file: F196222: Screen Recording 2022-10-11 at 4.27.06 PM.mov. (Show Details)

ginsu attached a referenced file: F196221: Screen Shot 2022-10-11 at 4.21.37 PM.png. (Show Details)

Harbormaster completed remote builds in B12737: Diff 17498.Oct 11 2022, 1:42 PM

ginsu requested review of this revision.Oct 11 2022, 1:42 PM

rohan accepted this revision.Oct 11 2022, 3:09 PM

This revision is now accepted and ready to land.Oct 11 2022, 3:09 PM

ginsu added a reviewer: Restricted Owners Package.Oct 11 2022, 7:17 PM

ginsu removed a reviewer: Restricted Owners Package. ginsu added 1 blocking reviewer(s): atul.

This revision now requires review to proceed.Oct 11 2022, 7:18 PM

Code change looks right.

However, the copy ("Learn more about Comm") seems a little too similar to "How Comm works" IMO. Saw that you're holding off on landing this one, so will want to get @ashoat's sign off before that.

landing/footer.react.js
50	In terms of copy, "Learn more about Comm" seems very close to "How Comm works"... might be confusing what exactly the distinction between the two is. (CC @ashoat on copy) But the code change looks right.

This revision is now accepted and ready to land.Oct 11 2022, 7:46 PM

ashoat added inline comments.Oct 11 2022, 8:42 PM

landing/footer.react.js
50	Valid, any suggestion?

rohan added inline comments.Oct 12 2022, 4:41 AM

landing/footer.react.js
50	What if we rename "Learn more about Comm" to "About Comm", since it includes details about the company, what the product is, and about the team (and more). Just throwing an idea out there.

ginsu added inline comments.Oct 12 2022, 7:42 AM

landing/footer.react.js
50	I agree with Rohan; I think we should rename "Learn more about Comm" to "About Comm", and additionally we should rename "How Comm works" to "Learn how Comm works".