Paths

Table of Contentst

[keyserver] Add descriptive error if assets.json can't be found
ClosedPublic
Actions

Authored by ashoat on Oct 12 2022, 10:26 AM.

Tags

None

Referenced Files

	F3401890: D5351.id17520.diff
	Mon, Dec 2, 2:26 PM

	F3401429: D5351.diff
	Mon, Dec 2, 12:04 PM

	Unknown Object (File)
	Wed, Nov 27, 1:11 AM

	Unknown Object (File)
	Mon, Nov 25, 10:35 PM

	Unknown Object (File)
	Mon, Nov 25, 10:35 PM

	Unknown Object (File)
	Mon, Nov 25, 10:35 PM

	Unknown Object (File)
	Tue, Nov 19, 4:23 PM

	Unknown Object (File)
	Tue, Nov 19, 4:23 PM

View All Files

Subscribers

• abosh

tomek

Details

Reviewers

rohan
atul

Commits

rCOMMd601297fca7c: [keyserver] Add descriptive error if assets.json can't be found

Summary

Noticed we had a descriptive error if the Webpack build couldn't be found, but not for assets.json.

Test Plan

Tested when assets.json was missing to make sure the new error was printed

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/nodeupgrade

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Oct 12 2022, 10:26 AM

Herald added subscribers: • abosh, tomek. · View Herald TranscriptOct 12 2022, 10:26 AM

Harbormaster completed remote builds in B12752: Diff 17517.Oct 12 2022, 10:37 AM

ashoat requested review of this revision.Oct 12 2022, 10:37 AM

Discussed in our sync

This revision is now accepted and ready to land.Oct 12 2022, 10:39 AM

Closed by commit rCOMMd601297fca7c: [keyserver] Add descriptive error if assets.json can't be found (authored by ashoat). · Explain WhyOct 12 2022, 11:13 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMd601297fca7c: [keyserver] Add descriptive error if assets.json can't be found.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

responders/

landing-handler.js

35 lines

website-responders.js

35 lines

Diff 17517

View Options

keyserver/src/responders/landing-handler.js