Change await import to fs.readFileSync when loading the
assets.
Details
Details
On both landing and web, ran yarn prod, then `yarn
prod-build` followed by yarn prod in keyserver. Both pages load fine.
Also changed the Node version in .nvmrc to 18.11.0 and they run fine as
well.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| keyserver/src/responders/landing-handler.js | ||
|---|---|---|
| 64 ↗ | (On Diff #17580) | Can we try to use an async method here? Sorry I didn't call this out in D5267! (Would be great if you could update that callsite too) Note you'll probably need to use promisify. Try git grep promisify to see how that works |
| keyserver/src/responders/website-responders.js | ||
| 86 ↗ | (On Diff #17580) | Here too |
| keyserver/src/responders/landing-handler.js | ||
|---|---|---|
| 65–66 ↗ | (On Diff #17587) | Can we separate the await out onto its own line (see proposed edit)? I prefer to avoid wrapping await with other calls since it can "hide" the await when reading the code Please apply this change to the other two codesites. Also worth just inlining assetsURL now that it fits |