we now derive the SIWE url so it works the same regardless if it's a sim/physical device or in prod. linear task
Details
Details
run app, sign out & tap SIWE on sim, then physical device. i also tested ignoring __DEV__ flag to ensure we visit https://comm.app/siwe & it worked.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/utils/url-utils.js | ||
|---|---|---|
| 13 ↗ | (On Diff #17621) | Let's call this productionLandingURL for now. We can refactor to productionURL later if we change the name of the landing folder |
| 53 ↗ | (On Diff #17621) | You're hard-coding an assumption here that basePath for landing will always be basePath for web with landing suffixed. This assumption is hard to grok from reading the code, and there's no reason that we have to bring web into this. Instead, you should (1) simplify your assumptions, and (2) be explicit with your assumptions. The reader should understand what the assumptions are from a quick glance at the code. Let's start with a function similar to getDevNodeServerURLFromHostname that returns http://${hostname}/commlanding |
Comment Actions
Please address feedback before landing
| native/utils/url-utils.js | ||
|---|---|---|
| 33 ↗ | (On Diff #17622) | This should be renamed to clarify that it only applies to dev, similar to its counterpart above |
Comment Actions
(Looks like intermittent buildkite issue caused the iOS failure. Looks like you already kicked it off again though)