Page MenuHomePhabricator
Differential D5437

[native] remove `grpc_client` folder on `clean-commoncpp` script
AbandonedPublic
Actions

Authored by kamil on Oct 20 2022, 8:08 AM.
Tags
None
Referenced Files
F3249460: D5437.diff
Fri, Nov 15, 2:53 PM
Unknown Object (File)
Sat, Nov 9, 6:29 PM
Unknown Object (File)
Sat, Nov 9, 11:13 AM
Unknown Object (File)
Sat, Nov 9, 7:31 AM
Unknown Object (File)
Oct 15 2024, 10:21 PM
Unknown Object (File)
Oct 10 2024, 6:56 AM
Unknown Object (File)
Oct 10 2024, 6:55 AM
Unknown Object (File)
Oct 10 2024, 6:54 AM
View All 81 Files
Subscribers
• abosh
ashoat
atul

Details

Reviewers
tomek
atul
marcin
ashoat
Summary

Removes generated folder which might cause Andriod build issues, more context in ENG-2091.

Test Plan

yarn clean-commoncpp

Diff Detail

Repository
rCOMM Comm
Branch
remove-grpc-folder
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Oct 20 2022, 8:08 AM
kamil held this revision as a draft.
Herald added subscribers: • abosh, atul, ashoat. · View Herald TranscriptOct 20 2022, 8:08 AM
kamil published this revision for review.Oct 20 2022, 8:13 AM
kamil edited the summary of this revision. (Show Details)
kamil edited the test plan for this revision. (Show Details)
kamil added reviewers: atul, marcin.
Harbormaster completed remote builds in B12931: Diff 17723.Oct 20 2022, 8:19 AM
ashoat requested changes to this revision.Oct 20 2022, 9:53 AM

Probs should do D5443 instead based on convo in ENG-2091, sorry for the misdirection!

This revision now requires changes to proceed.Oct 20 2022, 9:53 AM
kamil abandoned this revision.Oct 21 2022, 12:06 AM

Revision Contents
Changeset List

PathSize
native/
2 lines

Diff 17723

View Options

native/package.json

Loading...