Page MenuHomePhabricator
Differential D5447

more descriptive it statements, moved the RegEx text to a comment
AbandonedPublic
Actions

Authored by • manan on Oct 20 2022, 12:15 PM.
Tags
None
Referenced Files
F3247802: D5447.diff
Fri, Nov 15, 6:56 AM
Unknown Object (File)
Fri, Nov 8, 9:08 PM
Unknown Object (File)
Fri, Nov 8, 9:04 PM
Unknown Object (File)
Tue, Nov 5, 2:08 AM
Unknown Object (File)
Sep 30 2024, 8:49 PM
Unknown Object (File)
Sep 26 2024, 7:08 PM
Unknown Object (File)
Sep 26 2024, 7:07 PM
Unknown Object (File)
Sep 26 2024, 7:00 PM
View All 82 Files
Subscribers
• abosh
ashoat
tomek

Details

Reviewers
atul
rohan
ginsu
Summary

Made some changes to my original spoiler RegEx tests.

Test Plan

Tested results using https://regexr.com/

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D5335
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• manan created this revision.Oct 20 2022, 12:15 PM
Herald added subscribers: • abosh, tomek, ashoat. · View Herald TranscriptOct 20 2022, 12:15 PM
• manan mentioned this in D5358: Added tests for spoiler regex.Oct 20 2022, 12:20 PM
Harbormaster completed remote builds in B12946: Diff 17749.Oct 20 2022, 12:26 PM
• manan requested review of this revision.Oct 20 2022, 12:26 PM
ashoat added a comment.Oct 20 2022, 12:41 PM

This should probably be an update to an existing diff rather than a new diff

ginsu requested changes to this revision.Oct 20 2022, 1:23 PM

I agree with ashoat here you should rebase and update your changes for D5358! This should help, but let me know if you have any questions!

This revision now requires changes to proceed.Oct 20 2022, 1:23 PM
• manan abandoned this revision.Oct 20 2022, 1:46 PM

Amended changes to the original diff.

Revision Contents
Changeset List

PathSize
lib/
shared/
25 lines

Diff 17749

View Options

lib/shared/markdown.test.js

Loading...