Page MenuHomePhabricator

[landing] shuffled investor data
ClosedPublic

Authored by ginsu on Oct 25 2022, 1:26 PM.
Tags
None
Referenced Files
F3247885: D5482.id17929.diff
Fri, Nov 15, 7:23 AM
F3247425: D5482.diff
Fri, Nov 15, 5:21 AM
Unknown Object (File)
Sat, Nov 2, 11:24 PM
Unknown Object (File)
Tue, Oct 22, 2:37 PM
Unknown Object (File)
Oct 7 2024, 6:12 AM
Unknown Object (File)
Oct 7 2024, 6:12 AM
Unknown Object (File)
Oct 7 2024, 6:11 AM
Unknown Object (File)
Oct 7 2024, 6:06 AM

Details

Summary

shuffled investor data randomly so that every time a user refreshes the investor page, the order of investors should be different


Linear Task: ENG-2105

Test Plan

Please watch the before and after video demos to see the changes I made:

Before:

After:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu requested review of this revision.Oct 25 2022, 1:40 PM

Huh, I'm a little confused.

The video clearly shows that things are working as expected, but I assumed shuffledInvestorsData is defined and instantiated once and would remain the same indefinitely.. but looks like that assumption is incorrect

It's evaluated once per run of the JS code. The bundle will say _shuffle(investorsData), and the JS runtime that evaluates that bundle will generate a different shuffle every time it evaluates it

It's evaluated once per run of the JS code. The bundle will say _shuffle(investorsData), and the JS runtime that evaluates that bundle will generate a different shuffle every time it evaluates it

Ah gotcha, thanks for explaining

This revision is now accepted and ready to land.Oct 26 2022, 12:46 PM
This revision was automatically updated to reflect the committed changes.