Page MenuHomePhabricator
Differential D5472

[web] Calendar scrolling
ClosedPublic
Actions

Authored by michal on Oct 25 2022, 12:48 AM.
Tags
None
Referenced Files
F3523513: D5472.id18016.diff
Mon, Dec 23, 9:33 AM
F3523150: D5472.id17895.diff
Mon, Dec 23, 8:29 AM
Unknown Object (File)
Sun, Dec 8, 1:57 AM
Unknown Object (File)
Sun, Nov 24, 11:06 PM
Unknown Object (File)
Sun, Nov 24, 11:06 PM
Unknown Object (File)
Sun, Nov 24, 11:06 PM
Unknown Object (File)
Sun, Nov 24, 11:06 PM
Unknown Object (File)
Sun, Nov 24, 11:06 PM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
atul
• abosh
ginsu
Commits
rCOMM2412abadcb62: [web] Calendar scrolling
Summary

ENG-1678
This diff adds a scrollbar to the calendar if it's too big vertically.

image.png (1×2 px, 174 KB)

Test Plan

Test if calendar can be scrolled. Check if there is no scrollbar when it's not needed (the screen is high enough).

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

michal created this revision.Oct 25 2022, 12:48 AM
Herald added a subscriber: ashoat. · View Herald TranscriptOct 25 2022, 12:48 AM
michal edited the summary of this revision. (Show Details)Oct 25 2022, 12:48 AM
Harbormaster completed remote builds in B13022: Diff 17886.Oct 25 2022, 1:01 AM
michal requested review of this revision.Oct 25 2022, 1:01 AM
tomek requested changes to this revision.Oct 25 2022, 5:19 AM
tomek added inline comments.
web/calendar/calendar.css
19 ↗(On Diff #17886)

Why do we need to use absolute positioning? Is it possible to avoid id?

This revision now requires changes to proceed.Oct 25 2022, 5:19 AM
michal updated this revision to Diff 17895.Oct 25 2022, 6:34 AM

Used other method, without position: absolute. Moved padding-top to margin in nav because otherwise some of the calendar and scrollbar were cutoff at the bottom.

Harbormaster completed remote builds in B13028: Diff 17895.Oct 25 2022, 6:48 AM
ginsu accepted this revision.Oct 25 2022, 10:00 AM

nice looks good, I would also add some padding to the bottom of the calendar (maybe 8px) to give the calendar some space to "breathe" at the bottom

tomek accepted this revision.Oct 26 2022, 6:34 AM
This revision is now accepted and ready to land.Oct 26 2022, 6:34 AM
michal updated this revision to Diff 18016.Nov 2 2022, 2:17 AM

Rebase, add some padding at the bottom

Harbormaster completed remote builds in B13124: Diff 18016.Nov 2 2022, 2:30 AM
Closed by commit rCOMM2412abadcb62: [web] Calendar scrolling (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyNov 2 2022, 2:33 AM
This revision was automatically updated to reflect the committed changes.
Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM2412abadcb62: [web] Calendar scrolling.

Revision Contents
Changeset List

PathSize
web/
calendar/
8 lines

Diff 18017

View Options

web/calendar/calendar.css

Loading...