Allow for bundler to be used for pod install
Details
- Reviewers
atul varun ashoat - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rCOMMa6f8a2305759: [Nix] Add bundler for pod install
nix develop which bundle # shound point to nix store cd native bundle install cd ios bundle exec pod install
Diff Detail
- Repository
- rCOMM Comm
- Branch
- jonringer/bundler-nix
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
One change request, but high-level we probably won't be able to actually update package.json to use bundle exec pod install until we deprecate the existing development workflow, unless we also add installation instructions to the mainline dev environment instructions
native/Gemfile | ||
---|---|---|
4 | This file is defined by React Native and occasionally needs to be updated as part of upgrade, so let's avoid modifying it |
I think we can use bundle without adding anything to installation instructions? Looks like it gets included with ruby install (included in macOS + via brew)
atul@atuls-MacBook-Pro ios % where bundle /opt/homebrew/opt/ruby/bin/bundle /usr/bin/bundle
(might be missing context though)
Yeah but bundle exec pod install doesn't work without bundler (which is distinct from the bundle command)
Yeah but bundle exec pod install doesn't work without bundler (which is distinct from the bundle command)
The nix bundler package exposes both bundle and bundler commands
$ nix build .#bundler $ ls ./result/bin bundle bundler
native/Gemfile | ||
---|---|---|
4 | can't, 2.7.4 means == 2.7.4. ~> 2.7.4 means >=2.7.4, <2.8. Nix brings in 2.7.6 |
native/Gemfile | ||
---|---|---|
4 | Okay, that's fair. In that case should native/.ruby-version also be updated? Or is that file meant to be auto-generated or something? |
native/Gemfile | ||
---|---|---|
4 | I'm not super familiar with the best practices for ruby. Seems that rvm and rbenv are the tools which watch for this, but those aren't present in the nix environment. However, I think having alignment between environments makes more sense than less alignment between them. So I'll update the version pin. |