Page MenuHomePhabricator
Differential D5366

Introduce files in "services/lib/src" to clang formatter
ClosedPublic
Actions

Authored by marcin on Oct 14 2022, 5:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 6:07 PM
Unknown Object (File)
Sun, Nov 24, 12:40 PM
Unknown Object (File)
Sun, Nov 24, 12:40 PM
Unknown Object (File)
Sun, Nov 24, 12:40 PM
Unknown Object (File)
Wed, Nov 13, 6:35 PM
Unknown Object (File)
Sun, Nov 3, 12:06 AM
Unknown Object (File)
Sun, Nov 3, 12:06 AM
Unknown Object (File)
Sun, Nov 3, 12:06 AM
View All Files
Subscribers
• abosh
ashoat
atul

Details

Reviewers
tomek
• jon
• max
ashoat
Commits
rCOMMdd9f99ac1047: Introduce files in "services/lib/src" to clang formatter
Summary

This differential enables files in "services/lib/src" to be formatted with clang formatter.

Test Plan

Before applying this differential put some not formatted C++ code in ServerBidiReactorBase.h and run yarn clang-format-all. Code will not be formatted. Remove changes, apply diff and repeat process. Code will be formatted now.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Oct 14 2022, 5:04 AM
Herald added subscribers: • abosh, atul, ashoat. · View Herald TranscriptOct 14 2022, 5:04 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 14 2022, 5:06 AM
Harbormaster failed remote builds in B12792: Diff 17568!
Harbormaster completed remote builds in B12792: Diff 17568.Oct 14 2022, 5:17 AM
marcin requested review of this revision.Oct 14 2022, 5:17 AM
marcin added a child revision: D5367: Ensure Server{Write/Read/Bidi}ReactorBase derived class instance is deallocated after all thread pool tasks writing to its memory complete.Oct 14 2022, 5:33 AM
ashoat accepted this revision.Oct 14 2022, 6:28 AM
This revision is now accepted and ready to land.Oct 14 2022, 6:28 AM
marcin updated this revision to Diff 18261.Nov 9 2022, 5:03 AM

Rebase on master before landing

Harbormaster completed remote builds in B13313: Diff 18261.Nov 9 2022, 5:16 AM
Closed by commit rCOMMdd9f99ac1047: Introduce files in "services/lib/src" to clang formatter (authored by marcin). · Explain WhyNov 9 2022, 5:32 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMdd9f99ac1047: Introduce files in "services/lib/src" to clang formatter.

Revision Contents
Changeset List

PathSize
scripts/
4 lines
services/
lib/
src/
2 lines
2 lines
client-base-reactors/
2 lines
2 lines
2 lines

Diff 18261

View Options

scripts/get_clang_paths.js

Loading...
View Options

services/lib/src/BaseReactor.h

Loading...
View Options

services/lib/src/GlobalTools.cpp

Loading...
View Options

services/lib/src/client-base-reactors/ClientBidiReactorBase.h

Loading...
View Options

services/lib/src/client-base-reactors/ClientReadReactorBase.h

Loading...
View Options

services/lib/src/client-base-reactors/ClientWriteReactorBase.h

Loading...