Differential D5561

[Nix] Install comm cache in nix.conf
ClosedPublic
Actions

Authored by • jon on Nov 8 2022, 10:05 AM.

Tags

None

Referenced Files

	F3249332: D5561.id18327.diff
	Fri, Nov 15, 1:40 PM

	F3249328: D5561.id18219.diff
	Fri, Nov 15, 1:38 PM

	F3249008: D5561.diff
	Fri, Nov 15, 11:50 AM

	Unknown Object (File)
	Sat, Nov 9, 4:10 AM

	Unknown Object (File)
	Fri, Nov 8, 9:08 PM

	Unknown Object (File)
	Fri, Nov 8, 9:07 PM

	Unknown Object (File)
	Fri, Nov 8, 9:04 PM

	Unknown Object (File)
	Thu, Nov 7, 10:28 AM

View All 100 Files

Subscribers

Details

Reviewers

varun
atul

Commits

rCOMMc2393bbcca66: [Nix] Install comm cache in nix.conf

Summary

Use the legacy way to define an alternative binary cache.
This avoids trying to rely on experimental flakeConfig feature which
seem to need some time to stabilize, see
https://github.com/nixos/nix/issues/6672 for more details.

https://linear.app/comm/issue/ENG-2126

Test Plan

# On a non-NixOS machines (nix.conf is readonly)
cat /etc/nix/nix.conf
# confirm it's missing "https://comm.cachix.org" as a substituter

./scripts/install_nix.sh

# confirm "https://comm.cachix.org" is now a substituter

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Nov 8 2022, 10:05 AM

Herald added subscribers: • abosh, tomek, ashoat. · View Herald TranscriptNov 8 2022, 10:05 AM

• jon mentioned this in D5562: [Nix] Remove flakeConfig for cache.Nov 8 2022, 10:07 AM

Harbormaster completed remote builds in B13277: Diff 18219.Nov 8 2022, 10:15 AM

• jon requested review of this revision.Nov 8 2022, 10:15 AM

Was able to follow Test Plan successfully

This revision is now accepted and ready to land.Nov 8 2022, 10:47 AM

Closed by commit rCOMMc2393bbcca66: [Nix] Install comm cache in nix.conf (authored by • jon). · Explain WhyNov 10 2022, 9:38 AM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMMc2393bbcca66: [Nix] Install comm cache in nix.conf.

• jon mentioned this in rCOMM14088b6a8a36: [Nix] Remove flakeConfig for cache.

Revision Contents
Changeset List

Path

Size

scripts/

34 lines

Diff 18327

scripts/install_nix.sh

Loading...