[Nix] Remove flakeConfig for cache
ClosedPublic
Actions

Authored by • jon on Nov 8 2022, 10:07 AM.

Details

Reviewers

atul
varun

Commits

rCOMM14088b6a8a36: [Nix] Remove flakeConfig for cache

Summary

Now that install the binary caches through the
./script/install_nix.sh script, remove flakeConfig which doesn't appear
to be working as intended for substituters

Cleanup item for https://linear.app/comm/issue/ENG-2126

Depends on https://phab.comm.dev/D5561

Test Plan

nix develop

# no longer emits "Using saved setting for ..."

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Nov 8 2022, 10:07 AM

Herald added subscribers: • abosh, tomek, ashoat. · View Herald TranscriptNov 8 2022, 10:07 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 8 2022, 10:13 AM

Harbormaster failed remote builds in B13278: Diff 18220!

Harbormaster completed remote builds in B13278: Diff 18220.Nov 8 2022, 10:55 AM

• jon requested review of this revision.Nov 8 2022, 10:55 AM

Confirmed that things worked as expected

This revision is now accepted and ready to land.Nov 8 2022, 11:16 AM

Closed by commit rCOMM14088b6a8a36: [Nix] Remove flakeConfig for cache (authored by • jon). · Explain WhyNov 10 2022, 9:38 AM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMM14088b6a8a36: [Nix] Remove flakeConfig for cache.

Revision Contents
Changeset List

Path

Size

flake.nix

10 lines

Diff 18328

View Options

[Nix] Remove flakeConfig for cacheClosedPublicActions