[docs] Reorganize Nix mobile setup docs
ClosedPublic
Actions

Authored by ashoat on Nov 13 2022, 10:33 AM.

Details

Reviewers

• jon
atul
varun

Commits

rCOMMa67afcc048f2: [docs] Reorganize Nix mobile setup docs

Summary

I think it makes more sense this way for two reasons:

This part of nix_dev_env.md effectively serves as a table of contents for nix_mobile_setup.md, but the structure of the two don't currently align.
I want to avoid titling a section "Android Studio" since it implies that the first thing to do is install Android Studio. But now in D5624, JDK installation has to happen before Android Studio installation.
It makes sense to group the rest of the steps as general debugging tools since that's what they are.

Test Plan

N/A

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Nov 13 2022, 10:33 AM

Herald added 1 blocking reviewer(s): • jon. · View Herald TranscriptNov 13 2022, 10:33 AM

Herald added subscribers: • abosh, tomek. · View Herald Transcript

ashoat mentioned this in D5624: [docs] Copy JDK docs into Nix.Nov 13 2022, 10:33 AM

ashoat added a child revision: D5624: [docs] Copy JDK docs into Nix.Nov 13 2022, 10:33 AM

ashoat mentioned this in D5544: [Nix Docs] Add section about JDK for Android Studio.Nov 13 2022, 10:39 AM

ashoat added inline comments.Nov 13 2022, 10:41 AM

docs/nix_mobile_setup.md
106 ↗	(On Diff #18400)	I added "It’s necessary for some of the following steps." here. The rest of the green text was copy-pasted from the red stuff, with the exception of section headings

Harbormaster completed remote builds in B13416: Diff 18400.Nov 13 2022, 10:47 AM

ashoat requested review of this revision.Nov 13 2022, 10:47 AM

Went ahead and landed this without review because we have a new intern starting on Monday, so I'd like to land this before then so we can have him try the Nix workflow

This revision was not accepted when it landed; it landed in state Needs Review.Nov 13 2022, 12:14 PM

Closed by commit rCOMMa67afcc048f2: [docs] Reorganize Nix mobile setup docs (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMa67afcc048f2: [docs] Reorganize Nix mobile setup docs.

GitHub <noreply@github.com> mentioned this in rCOMM27d586bba387: Fix typo in D5625.Nov 13 2022, 12:14 PM