[desktop] Draggable window
ClosedPublic
Actions

Authored by michal on Nov 15 2022, 12:50 AM.

Details

Reviewers

tomek
atul
• abosh
kamil

Commits

rCOMMf26876751866: [desktop] Draggable window

Summary

After hiding the titlebar users can't drag the window using it. The standard way to do it is to add a -webkit-app-region: drag property to our custom titlebar.

Test Plan

Check that you can drag the window using the titlebar
Check that you can't drag using buttons

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

michal created this revision.Nov 15 2022, 12:50 AM

Herald added a subscriber: ashoat. · View Herald TranscriptNov 15 2022, 12:50 AM

michal added a parent revision: D5631: [desktop] Double-click to maximize or minimize.Nov 15 2022, 12:54 AM

michal added a child revision: D5633: [desktop] Notification badge.

Harbormaster completed remote builds in B13431: Diff 18425.Nov 15 2022, 1:02 AM

michal requested review of this revision.Nov 15 2022, 1:02 AM

I think it would be good for @kamil to review this too – he's looking at ENG-1687: Explore sqlite-worker NPM package, which is related to ENG-1685: Stateful web client, which I think has some connection to the Electron app. Given this overlap I think it makes sense for @michal to review @kamil's diffs in the space, and for @kamil to review @michal's diffs in the space.

Have you checked if "traffic lights" buttons (top-left corner) aren't draggable?

web/app.react.js
194–196 ↗	(On Diff #18425)	Shouldn't we add the new class to the `header`?
web/style.css
88–93 ↗	(On Diff #18425)	Why do we make this draggable?

This revision now requires changes to proceed.Nov 15 2022, 6:18 AM

michal added inline comments.Nov 16 2022, 6:27 AM

web/app.react.js
194–196 ↗	(On Diff #18425)	Yeah, that makes sense.
web/style.css
88–93 ↗	(On Diff #18425)	Not sure what you mean? The `.wordmark` is set to `no-drag` (because it's a button). Or is this the same comment as "Shouldn't we add the new class to the header?"?