[native] remove additional `TerminateApp.mm` entry in `pbxproj` file
ClosedPublic
Actions

Authored by kamil on Nov 21 2022, 4:18 AM.

Details

Reviewers

marcin
ashoat

Commits

rCOMM66f1d74860ca: [native] remove additional `TerminateApp.mm` entry in `pbxproj` file

Summary

This diff removes unnecessary line connected with TerminateApp from project.pbxproj which right now was removed anyway after pod install.

Context in: D5618#inline-37798 and ENG-2297.

Test Plan

Check if there are no git changes after hitting pod install
Same test plan as in D5618

Diff Detail

Repository

rCOMM Comm

Branch

fix-terminate-app

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Nov 21 2022, 4:18 AM

kamil held this revision as a draft.

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptNov 21 2022, 4:18 AM

kamil published this revision for review.Nov 21 2022, 4:22 AM

kamil edited the summary of this revision. (Show Details)

kamil edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B13618: Diff 18653.Nov 21 2022, 4:31 AM

ashoat accepted this revision.Nov 21 2022, 4:49 AM

This revision is now accepted and ready to land.Nov 21 2022, 4:49 AM

Closed by commit rCOMM66f1d74860ca: [native] remove additional `TerminateApp.mm` entry in `pbxproj` file (authored by kamil). · Explain WhyNov 21 2022, 5:00 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM66f1d74860ca: [native] remove additional `TerminateApp.mm` entry in `pbxproj` file.

tomek mentioned this in D5684: [services] Tunnelbroker - Removing of `get` and `send` methods from API and native codebase.Nov 21 2022, 5:01 AM

Revision Contents
Changeset List

Path

Size

native/

ios/

Comm.xcodeproj/

project.pbxproj

1 line

Diff 18653

View Options

native/ios/Comm.xcodeproj/project.pbxproj

[native] remove additional `TerminateApp.mm` entry in `pbxproj` fileClosedPublicActions