[native] Removing `codegen-grpc` from native
ClosedPublic
Actions

Authored by • max on Nov 23 2022, 4:24 PM.

Details

Reviewers

• jon
atul
varun
ashoat

Commits

rCOMM0810d1d11618: [native] Removing `codegen-grpc` from native

Summary

This diff removes the codegen-grpc yarn command from the native. We are removed the C++ gRPC from the client and the compilation of the gRPC files will be handled by the cargo building process. Also, we are removing running this command from the documentation and shared folder because gRPC generation for the rest of the C++ codebase is done using the CMakeFile generation command.

Linear task: ENG-2276

Test Plan

Native builds are successfully passed.

Diff Detail

Repository

rCOMM Comm

Branch

remove-grpc-gen-from-native

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Nov 23 2022, 4:24 PM

• max held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptNov 23 2022, 4:24 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald Transcript

• max added a parent revision: D5706: [native] Remove gRPC related C++ code and packages from iOS and Android.Nov 23 2022, 4:25 PM

• max published this revision for review.Nov 23 2022, 4:29 PM

• max edited the summary of this revision. (Show Details)

• max edited the test plan for this revision. (Show Details)

• max added reviewers: atul, varun. • max removed 1 blocking reviewer(s): • jon.

• max retitled this revision from [native] Remove `codegen-grpc` from native to [native] Removing `codegen-grpc` from native.

Harbormaster completed remote builds in B13715: Diff 18795.Nov 23 2022, 4:33 PM

Can you please do more research to figure out everything that can be deleted here? A single git grep mark-generated popped up two more places

Delete mark-generated.sh as well

native/package.json
19–20	`shared/package.json` too

This revision now requires changes to proceed.Nov 24 2022, 9:25 AM

• max planned changes to this revision.Nov 28 2022, 4:28 AM

Removing of the codegen-grpc from shared and mark-generated.

In D5714#170536, @ashoat wrote:

Can you please do more research to figure out everything that can be deleted here? A single git grep mark-generated popped up two more places
Delete mark-generated.sh as well

Of course! The mark-generated is used only for the codegen-grpc purposes and should be removed as well, thanks!

• max marked an inline comment as done.Nov 28 2022, 4:50 AM

• max added inline comments.