Page MenuHomePhabricator
Differential D5740

[Nix] Ensure cargo bin is on PATH
ClosedPublic
Actions

Authored by • jon on Nov 28 2022, 9:48 AM.
Tags
None
Referenced Files
F3514457: D5740.diff
Sun, Dec 22, 5:03 AM
Unknown Object (File)
Fri, Nov 22, 8:00 AM
Unknown Object (File)
Fri, Nov 22, 8:00 AM
Unknown Object (File)
Fri, Nov 22, 8:00 AM
Unknown Object (File)
Fri, Nov 22, 8:00 AM
Unknown Object (File)
Fri, Nov 22, 7:57 AM
Unknown Object (File)
Fri, Nov 22, 7:45 AM
Unknown Object (File)
Nov 6 2024, 7:05 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
varun
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Owners Package(Owns No Changed Paths)
Commits
rCOMM39799a0c43cc: [Nix] Ensure cargo bin is on PATH
Summary

Unless a user has their shell configured to add the subdirectory to
their path, then applications installed through cargo such as cargo-lipo will
not be found.

https://linear.app/comm/issue/ENG-2359

Test Plan
nix develop

echo $PATH | grep .cargo/bin > /dev/null && echo "Cargo bin present"

Diff Detail

Repository
rCOMM Comm
Branch
jonringer/add-cargo-bin
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Nov 28 2022, 9:48 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 28 2022, 9:48 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Nov 28 2022, 9:50 AM
Harbormaster failed remote builds in B13795: Diff 18886!
• jon updated this revision to Diff 18889.Nov 28 2022, 10:05 AM

Make older shellcheck happy

Harbormaster completed remote builds in B13798: Diff 18889.Nov 28 2022, 10:16 AM
• jon requested review of this revision.Nov 28 2022, 10:16 AM
atul added reviewers: Restricted Owners Package, Restricted Owners Package.Nov 28 2022, 3:09 PM
atul accepted this revision.Nov 28 2022, 3:48 PM
varun accepted this revision.Nov 28 2022, 10:12 PM
This revision is now accepted and ready to land.Nov 28 2022, 10:12 PM
• jon updated this revision to Diff 18964.Nov 29 2022, 9:19 AM

Merge conflicts

Harbormaster completed remote builds in B13846: Diff 18964.Nov 29 2022, 9:32 AM
Closed by commit rCOMM39799a0c43cc: [Nix] Ensure cargo bin is on PATH (authored by • jon). · Explain WhyNov 29 2022, 9:35 AM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMM39799a0c43cc: [Nix] Ensure cargo bin is on PATH.

Revision Contents
Changeset List

PathSize
scripts/
5 lines

Diff 18889

View Options

scripts/source_development_defaults.sh

Loading...