Page MenuHomePhabricator

[docs] Remove 'you can' instance from non-optional steps
ClosedPublic

Authored by adar on Nov 28 2022, 10:30 AM.
Tags
None
Referenced Files
F3247319: D5743.id18891.diff
Fri, Nov 15, 4:42 AM
F3247284: D5743.id18906.diff
Fri, Nov 15, 4:32 AM
F3246932: D5743.diff
Fri, Nov 15, 2:30 AM
Unknown Object (File)
Wed, Nov 6, 7:05 PM
Unknown Object (File)
Wed, Nov 6, 6:16 AM
Unknown Object (File)
Mon, Nov 4, 3:48 PM
Unknown Object (File)
Mon, Nov 4, 3:48 PM
Unknown Object (File)
Tue, Oct 22, 11:53 AM

Details

Reviewers
atul
varun
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rCOMMb3b267eab769: [docs] Remove 'you can' instance from non-optional steps
Summary

This diff updates our doc so that we are explicit about certain steps being required rather than optional, as was previously implied by using "you can."

Link to linear

Test Plan

Verify Markdown looks as expected.

Screen Shot 2022-11-28 at 1.32.15 PM.png (550×1 px, 65 KB)

Screen Shot 2022-11-28 at 1.31.26 PM.png (456×1 px, 91 KB)

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

adar edited the summary of this revision. (Show Details)

I think the intent was to avoid an imperative or ordering tone. Probably want something like Please run the following: instead of Run this command:

Then again, I'm terrible at diction.

I think the intent was to avoid an imperative or ordering tone.

I believe the intent here was to remove "you can" because it could give the impression that a step is optional.

(@adar might be helpful to include a Linear link or something in the future to provide that context)

This revision is now accepted and ready to land.Nov 28 2022, 11:00 AM
atul added a reviewer: Restricted Owners Package.Nov 28 2022, 11:02 AM
This revision now requires review to proceed.Nov 28 2022, 11:02 AM
In D5743#171198, @atul wrote:

I think the intent was to avoid an imperative or ordering tone.

I believe the intent here was to remove "you can" because it could give the impression that a step is optional.

(@adar might be helpful to include a Linear link or something in the future to provide that context)

My $0.02 is that we might not need to include "run this command" at all in the docs; I'd imagine most of our target audience would get that text in a markdown code block implies for the user to execute a given command.
NBD, just from what I've seen in some other docs before, I do understand how being explicit removes any possible ambiguity.

I believe the intent here was to remove "you can" because it could give the impression that a step is optional.

Then to @adar credit, the steps are not optional.

My $0.02 is that we might not need to include "run this command" at all in the docs; I'd imagine most of our target audience would get that text in a markdown code block implies for the user to execute a given command.
NBD, just from what I've seen in some other docs before, I do understand how being explicit removes any possible ambiguity.

Yeah personally agree, but defer to the docs folks since they have pretty specific language preferences

varun added a subscriber: varun.

I'm fine with the current revision or removing the "run this command" altogether

This revision is now accepted and ready to land.Nov 28 2022, 12:09 PM