Page MenuHomePhabricator

[Nix] Ensure cargo bin is on PATH
ClosedPublic

Authored by jon on Nov 28 2022, 9:48 AM.
Tags
None
Referenced Files
F3515517: D5740.id18968.diff
Sun, Dec 22, 9:05 AM
F3514457: D5740.diff
Sun, Dec 22, 5:03 AM
Unknown Object (File)
Nov 22 2024, 8:00 AM
Unknown Object (File)
Nov 22 2024, 8:00 AM
Unknown Object (File)
Nov 22 2024, 8:00 AM
Unknown Object (File)
Nov 22 2024, 8:00 AM
Unknown Object (File)
Nov 22 2024, 7:57 AM
Unknown Object (File)
Nov 22 2024, 7:45 AM
Subscribers

Details

Reviewers
atul
varun
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Owners Package(Owns No Changed Paths)
Commits
rCOMM39799a0c43cc: [Nix] Ensure cargo bin is on PATH
Summary

Unless a user has their shell configured to add the subdirectory to
their path, then applications installed through cargo such as cargo-lipo will
not be found.

https://linear.app/comm/issue/ENG-2359

Test Plan
nix develop

echo $PATH | grep .cargo/bin > /dev/null && echo "Cargo bin present"

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 28 2022, 9:50 AM
Harbormaster failed remote builds in B13795: Diff 18886!

Make older shellcheck happy

atul added reviewers: Restricted Owners Package, Restricted Owners Package.Nov 28 2022, 3:09 PM
This revision is now accepted and ready to land.Nov 28 2022, 10:12 PM
This revision was automatically updated to reflect the committed changes.